fix: CheckQuorumConnections should not be running on regular non-watching nodes #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
fix_CheckQuorumConnections
branch
from
285058a
to
c374778
Compare
UdjinM6
changed the title
UdjinM6
force-pushed
the
fix_CheckQuorumConnections
branch
from
c374778
to
4e038d8
Compare
knst
reviewed
Nov 28, 2023
| @@ -301,6 +301,10 @@ void CQuorumManager::UpdatedBlockTip(const CBlockIndex* pindexNew, bool fInitial | |||
|
|
|||
| void CQuorumManager::CheckQuorumConnections(const Consensus::LLMQParams& llmqParams, const CBlockIndex* pindexNew) const | |||
| { | |||
| if (!fMasternodeMode && !utils::IsWatchQuorumsEnabled()) { | |||
There was a problem hiding this comment.
should not it be CQuorumManager::UpdatedBlockTip instead?
void CQuorumManager::UpdatedBlockTip(const CBlockIndex* pindexNew, bool fInitialDownload) const
+ if (!fMasternodeMode && !utils::IsWatchQuorumsEnabled()) return;
if (!m_mn_sync->IsBlockchainSynced()) {
return;
}mapQuorumData seems used only for MNs; CleanupOldQuorumData and TriggerQuorumDataRecoveryThreads both check flags fMasternodeMode too.
There was a problem hiding this comment.
Good catch! 👍 There are indeed more related things to fix. I opened #5745 to address them all.
|
superseded by #5745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
No need to waste CPU on regular non-watching nodes
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: