Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use proper GitHub.repository and add an echo for testing #5757

Merged
merged 3 commits into from
Dec 6, 2023
Merged

fix: use proper GitHub.repository and add an echo for testing #5757

merged 3 commits into from
Dec 6, 2023

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

What was done?

Add an echo

How Has This Been Tested?

Breaking Changes

None

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 20.1 milestone Dec 6, 2023
@PastaPastaPasta PastaPastaPasta changed the title chore: add an echo to validate link fix: use proper GitHub.repository and add an echo for testing Dec 6, 2023
knst
knst previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (see nit, but kinda ok for debug for temporary)

contrib/containers/deploy/Dockerfile.GitHubActions.Release Outdated Show resolved Hide resolved
knst
knst approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 2099a5c into dashpay:develop Dec 6, 2023
7 checks passed
@PastaPastaPasta PastaPastaPasta deleted the test-GITHUB_REPO branch December 6, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knst knst knst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
2 participants
@PastaPastaPasta @knst