backport: partial merge bitcoin#26532: wallet: bugfix, invalid crypted key "checksum_valid" set #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cksum_valid" set backports cc5a5e8 only ``` wallet: bugfix, invalid crypted key "checksum_valid" set At wallet load time, we set the crypted key "checksum_valid" variable always to false. Which, on every wallet decryption call, forces the process to re-write the entire ckeys to db when it's not needed. ```
UdjinM6
changed the title
knst
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
utACK
I tried to backport regtest for this issue (see commit bitcoin@13d9760) but there's indeed too many conflicts at the moment, better to skip it for now.
PastaPastaPasta
approved these changes
Dec 11, 2023
ogabrielides
pushed a commit
to ogabrielides/dash
that referenced
this pull request
Dec 22, 2023
backport: partial merge bitcoin#26532: wallet: bugfix, invalid crypted key "checksum_valid" set
PastaPastaPasta
added a commit
to ogabrielides/dash
that referenced
this pull request
Dec 24, 2023
backport: partial merge bitcoin#26532: wallet: bugfix, invalid crypted key "checksum_valid" set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Backports the actual fix only (cc5a5e8) because of merge conflicts.
The bug was
introducedbackported via c0c00f9 from #5360.What was done?
How Has This Been Tested?
try to unlock a wallet with lots of keys w/ and w/out this patch
Breaking Changes
n/a
Checklist: