fix(rpc)!: require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc
#5772
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
UdjinM6
changed the title
proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpcproTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc
UdjinM6
changed the title
proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpcproTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc
|
Release notes + add text to "Breaking changes" section of pr? |
knst
reviewed
Dec 22, 2023
| @@ -730,6 +730,9 @@ static UniValue quorum_getdata(const JSONRPCRequest& request, const LLMQContext& | |||
| } else { | |||
| throw JSONRPCError(RPC_INVALID_PARAMETER, "proTxHash missing"); | |||
| } | |||
| } else if (!request.params[4].isNull()) { | |||
| // Require no proTxHash otherwise | |||
| throw JSONRPCError(RPC_INVALID_PARAMETER, "Should not specify proTxHash"); | |||
There was a problem hiding this comment.
is it easy to make functional test for this case? 🤔
PastaPastaPasta
requested changes
Jan 9, 2024
UdjinM6
force-pushed
the
require_no_protx
branch
from
c9752ea
to
db09b6b
Compare
UdjinM6
force-pushed
the
require_no_protx
branch
2 times, most recently
from
f635cd7
to
00a176f
Compare
UdjinM6
force-pushed
the
require_no_protx
branch
from
00a176f
to
5770763
Compare
…PTED_CONTRIBUTIONS` in `quorum getdata` rpc
UdjinM6
force-pushed
the
require_no_protx
branch
from
5770763
to
f18b4e8
Compare
|
Anything blocking this? or should we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Because when we ask for a quorum wide data only (
QUORUM_VERIFICATION_VECTOR) and not for a data about one specific MNproTxHashis not used in any way in this case and should not be provided. If it still was provided then maybe user doesn't quite understand what he is doing exactly or maybe he made a typo indataMask.What was done?
How Has This Been Tested?
Breaking Changes
quorum getdataRPC will no longer allowproTxHashto be specified whendataMaskis set to1.Checklist: