refactor: resolve a lot of sonarlint and clang-tidy warnings in llmq code #5773
Conversation
PastaPastaPasta
changed the title
UdjinM6
force-pushed
the
refactor-llmq2
branch
from
ad78e3e
to
f6123d4
Compare
|
Guix Automation has began to build this PR tagged as v20.1.0-devpr5773.f6123d42. A new comment will be made when the image is pushed. |
|
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v20.1.0-devpr5773.f6123d42. The image should be on dockerhub soon. |
|
Guix Automation has failed due to the HEAD commit not being signed by an authorized core-team member. Please rebase and sign or push a new empty signed commit to allow Guix build to happen. |
1 similar comment
|
Guix Automation has failed due to the HEAD commit not being signed by an authorized core-team member. Please rebase and sign or push a new empty signed commit to allow Guix build to happen. |
PastaPastaPasta
force-pushed
the
refactor-llmq2
branch
from
c3072bc
to
21b2f1c
Compare
|
|
||
| { | ||
| const bool relay = [&]() { |
There was a problem hiding this comment.
smart :D I am always annoyed by passing variables out of LOCK scope
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
refactor-llmq2
branch
from
21b2f1c
to
6d776a1
Compare
| for (auto& p : qcs) { | ||
| auto& qc = p.second; | ||
| for (auto& [_, qc2] : qcs) { | ||
| auto& qc = qc2; // cannot capture structured binding into lambda |
There was a problem hiding this comment.
Huh; interesting, but I think it's fine as is
PastaPastaPasta
force-pushed
the
refactor-llmq2
branch
from
6d776a1
to
bf57b15
Compare
Issue being fixed or feature implemented
Resolve a lot of sonarlint and clang-tidy warnings. Please see individual commits
What was done?
How Has This Been Tested?
make checkBreaking Changes
Should be none
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.