backport: bitcoin#18152 #5804
Merged
backport: bitcoin#18152 #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Previous discussion is here #5802 (comment). I think the cleanest way to fix this is to introduce another Things to test from Console once qt node is fully synced:
My results: |
|
I just realised, that a function |
|
yeah, technically both these cases are similar to switching back to IBD so using |
|
This pull request has conflicts, please rebase. |
UdjinM6
approved these changes
Jan 10, 2024
PastaPastaPasta
approved these changes
Jan 11, 2024
… GUI a0d0f1c refactor: Remove Node:: queries from GUI (Hennadii Stepanov) 06d519f qt: Add SynchronizationState enum to signal parameter (Hennadii Stepanov) 3c709aa refactor: Remove Node::getReindex() call from GUI (Hennadii Stepanov) 1dab574 refactor: Pass SynchronizationState enum to GUI (Hennadii Stepanov) 2bec309 refactor: Remove unused bool parameter in RPCNotifyBlockChange() (Hennadii Stepanov) 1df7701 refactor: Remove unused bool parameter in BlockNotifyGenesisWait() (Hennadii Stepanov) Pull request description: This PR is a followup of bitcoin#18121 and: - addresses confusion about GUI notification throttling conditions (**luke-jr**'s [comment](bitcoin#18121 (comment)), **ryanofsky**'s [comment](bitcoin#18121 (comment))) - removes `isInitialBlockDownload()` call from the GUI back to the node (on macOS). See: **ryanofsky**'s [comment](bitcoin#18121 (review)) ACKs for top commit: jonasschnelli: Core Review ACK a0d0f1c (modulo [question](bitcoin#18152 (review))). ryanofsky: Code review ACK a0d0f1c. Only changes since last review were rebase and tweaking SynchronizationState enum declaration as suggested (thanks!) Tree-SHA512: b6a712a710666e763aeee0d5440de1391a4c6c8f7fa661888773e1ba59e9e0f83654ee384d4edc704031be7eb25616e5eca2a6e26058d3efb7f64c47f9ed7316
PastaPastaPasta
force-pushed
the
bp-18152
branch
from
2a5fa62 to
5758a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
It splits from #5802 due to non-trivial decisions regards
updateNumBlocksusageWhat was done?
Backport bitcoin#18152
How Has This Been Tested?
Run unit/functional tests; tried to sync blockchain; reindex and watch a spinner and progress bar.
Breaking Changes
N/A
Checklist: