Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): fix for getassetunlockstatuses parameters parsing #5848

Closed
wants to merge 1 commit into from
Closed

fix(rpc): fix for getassetunlockstatuses parameters parsing #5848

wants to merge 1 commit into from

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Jan 28, 2024 •
edited by knst
Loading

Issue being fixed or feature implemented

getassetunlockstatuses was failing to parse parameters when calling from CLI.

Credits to knst

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides added the RPC Some notable changes to RPC params/behaviour/descriptions label Jan 28, 2024
@ogabrielides ogabrielides added this to the 20.1 milestone Jan 28, 2024
knst
knst approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

UdjinM6
UdjinM6 approved these changes Jan 28, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ogabrielides
Copy link
Collaborator Author

Closing as fix will be contained in #5849

@ogabrielides ogabrielides deleted the getassetunlock_rpc_fix branch January 29, 2024 13:50
@UdjinM6 UdjinM6 removed this from the 20.1 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst knst approved these changes

@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogabrielides @knst @UdjinM6