-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): quorum dkginfo
rpc
#5853
Conversation
Guix Automation has began to build this PR tagged as v20.1.0-devpr5853.8386a3d6. A new comment will be made when the image is pushed. |
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v20.1.0-devpr5853.8386a3d6. The image should be on dockerhub soon. |
Does this mean this new RPC can not be used for Evonodes ? Is there a different approach to masternodes (this pull request) and evonodes (adds a check in stopNodeTaskFactory through a Platform pull request). Or are both pull requests focused just on masternodes for now ? See : dashpay/platform#1683 |
I don't think so. In my mind (and I think how it's referred to here), an evonode is just a particular type of masternode. Regular MNs and evonodes are both subsets of the generic "masternode". |
WOW! This could be really useful, if it works ! |
It is not better to slot this RPC under |
Yes, you are right. |
It could be valuable to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few suggestions, see below (all of them squashed 44467c0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for squash merge
Issue being fixed or feature implemented
Dashmate wanted a way to know if it is safe to restart the masternode.
This new RPC indicates the number of active DKG sessions, and the number of blocks until next potential DKG.
What was done?
Examples of responses:
{'active_dkgs': 0, 'next_dkg': 22}
How Has This Been Tested?
feature_llmq_rotation.py
was updatedBreaking Changes
no
Checklist: