Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: merge bitcoin#24024, #23880, #24909, #24178, #24171, #25404, #25514, #25720, partial bitcoin#23832, #24169, #25454 (headers backports) #6097

Merged
merged 13 commits into from
Aug 9, 2024

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    9399f90 View commit details
    Browse the repository at this point in the history
  2. merge bitcoin#24024: Remove cs_main lock annotation from ChainstateMa…

    …nager.m_blockman
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9f7ac69 View commit details
    Browse the repository at this point in the history
  3. merge bitcoin#23880: Serialize cmpctblock at most once in NewPoWValid…

    …Block
    
    this commit will not work with `--enable-c++20` as c++20 does away with
    aggregate initialization when constructors are declared. a partial
    backport of bitcoin#24169 will sort that out.
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    27e885d View commit details
    Browse the repository at this point in the history
  4. partial bitcoin#24169: Add --enable-c++20 option

    includes:
    - fae6790
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    70485cb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bcafa28 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a04290f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ed871d2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0574a7d View commit details
    Browse the repository at this point in the history
  9. test: drop genesis block from blockheader_testnet3

    bitcoin#25454 introduces a 10 point penalty for remitting more than
    MAX_BLOCKS_TO_ANNOUNCE unconnected block headers. Whether they are
    connected or not is determined by taking the first entry and running
    its hashPrevBlock through LookupBlockIndex. This new behaviour causes a
    test failure in p2p_dos_header_tree.py in Dash.
    
    Bitcoin doesn't face a test failure with this new behaviour as the first
    non-fork block in its test data is the dump for block 1 (00000000b873e7
    9784647a6c82962c70d228557d24a747ea4d1b8bbe878e1206) but Dash uses block
    0 (00000bafbc94add76cb75e2ec92894837288a481e5c005f6563d91623bf8bc2c),
    the genesis block.
    
    By definition of a genesis block, it has a hashPrevBlock of 0, which
    cannot be looked up. This trips the penalty. This doesn't cause any
    problems in the field as nobody is expected to ever broadcast the
    genesis block but it does cause a test failure for us.
    
    We need to correct that by getting rid of the genesis block from the
    test data.
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    abccb2d View commit details
    Browse the repository at this point in the history
  10. revert: Fix duplicate initial headers sync

    commits reverted:
    - 753ed61
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    26d477b View commit details
    Browse the repository at this point in the history
  11. partial bitcoin#25454: Avoid multiple getheaders messages in flight t…

    …o the same peer
    
    excludes:
    - 99f4785
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c9923ca View commit details
    Browse the repository at this point in the history
  12. merge bitcoin#25514: Move CNode::nServices and CNode::nLocalServices …

    …to Peer
    
    Co-authored-by: UdjinM6 <[email protected]>
    2 people authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0f9ece0 View commit details
    Browse the repository at this point in the history
  13. merge bitcoin#25720: Reduce bandwidth during initial headers sync whe…

    …n a block is found
    kwvg authored and PastaPastaPasta committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c92b0f5 View commit details
    Browse the repository at this point in the history