Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: initialize variables in the header instead #6194

Merged
merged 2 commits into from
Aug 20, 2024
Merged

refactor: initialize variables in the header instead #6194

merged 2 commits into from
Aug 20, 2024

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Don't initialize via initializer lists when avoidable

What was done?

Initialize in the header

How Has This Been Tested?

building

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 22 milestone Aug 11, 2024
UdjinM6
UdjinM6 approved these changes Aug 12, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3e788ed

@PastaPastaPasta PastaPastaPasta merged commit c8734e2 into dashpay:develop Aug 20, 2024
7 of 10 checks passed
@PastaPastaPasta PastaPastaPasta deleted the refac-gov-simple branch August 20, 2024 20:35
@UdjinM6 UdjinM6 modified the milestones: 22, 21.2 Aug 23, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
2 participants
@PastaPastaPasta @UdjinM6