Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop unused InstantSendManager from blockheaderToJSON #6395

Merged
merged 1 commit into from
Nov 16, 2024
Merged

refactor: drop unused InstantSendManager from blockheaderToJSON #6395

merged 1 commit into from
Nov 16, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Nov 16, 2024

What was done?

Trivial refactoring - see a commit

How Has This Been Tested?

Run unit and functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)

@knst knst added this to the 22 milestone Nov 16, 2024
UdjinM6
UdjinM6 approved these changes Nov 16, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3a48c7f

@UdjinM6 UdjinM6 modified the milestones: 22, 22.1 Nov 16, 2024
PastaPastaPasta
PastaPastaPasta approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3a48c7f

@PastaPastaPasta PastaPastaPasta merged commit 495171b into dashpay:develop Nov 16, 2024
35 checks passed
@knst knst deleted the refactor-blockheaderToJSON branch November 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.
3 participants
@knst @UdjinM6 @PastaPastaPasta