Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: 24306, 24312, 24371 #6398

Merged

Commits on Nov 17, 2024

  1. Merge bitcoin#24306: util: Make ArgsManager::GetPathArg more widely u…

    …sable
    
    60aa179 Use GetPathArg where possible (Pavol Rusnak)
    5b946ed util, refactor: Use GetPathArg to read "-settings" value (Ryan Ofsky)
    687e655 util: Add GetPathArg default path argument (Ryan Ofsky)
    
    Pull request description:
    
      Improve `ArgsManager::GetPathArg` method added in recent PR bitcoin#24265, so it is usable more places. This PR starts to use it for the `-settings` option. This can also be helpful for bitcoin#24274 which is parsing more path options.
    
      - Add `GetPathArg` default argument so it is less awkward to use to parse options that have default values.
      - Fix `GetPathArg` negated argument handling. Return path{} not path{"0"} when path argument is negated.
      - Add unit tests for default and negated cases
      - Move `GetPathArg` method declaration next to `GetArg` declaration. The two methods are close substitutes for each, so this should help keep them consistent and make them more discoverable.
    
    ACKs for top commit:
      w0xlt:
        Tested ACK 60aa179 on Ubuntu 21.10
      hebasto:
        re-ACK 60aa179
    
    Tree-SHA512: 3d24b885d8bbeef39ea5d0556e2f09b9e5f4a21179cef11cbbbc1b84da29c8fb66ba698889054ce28d80bc25926687654c8532ed46054bf5b2dd1837866bd1cd
    MarcoFalke authored and PastaPastaPasta committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    d96983a View commit details
    Browse the repository at this point in the history
  2. Merge bitcoin#24312: addrman: Log too low compat value

    fa097d0 addrman: Log too low compat value (MarcoFalke)
    
    Pull request description:
    
      Before this patch, when writing a negative `lowest_compatible` value, it would be read as a positive value. For example `-32` will be read as `224`. There is generally nothing wrong with that. Though, similarly there shouldn't be anything wrong with refusing to read a negative value. I find the code after this patch more logical than before. Also, this allows dropping a file-wide sanitizer suppression.
    
      In practice none of this should ever happen. Bitcoin Core would never write a negative `lowest_compatible` in normal operation, unless the file storage is later corrupted by external influence.
    
    ACKs for top commit:
      mzumsande:
        re-ACK fa097d0
    
    Tree-SHA512: 9aae7b8fe666f52f667f149667025e0160cef1a793cc4d392e36608f65c2bee8096da429235118f40a3368f327aabe30f3732ae78c5874648ea6f423f2687b65
    MarcoFalke authored and PastaPastaPasta committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    3383b79 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    562e3f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba7e500 View commit details
    Browse the repository at this point in the history