Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache built #6402

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Depends build didn't seem to be caching properly

What was done?

changed depends/${{ matrix.host }} to depends/built as gitlab does

How Has This Been Tested?

Depends "build" now takes only ~1 minute instead of ~15 minutes in CI: https://github.com/PastaPastaPasta/dash/actions/runs/11899038167

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9604d87

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9604d87

@PastaPastaPasta PastaPastaPasta merged commit 65c5f46 into dashpay:develop Nov 18, 2024
9 of 12 checks passed
@PastaPastaPasta PastaPastaPasta deleted the ci-cache-built branch November 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants