Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create helper function RelayRecoveredSig inside peerman #6423

Merged
merged 2 commits into from
Nov 22, 2024
Merged

refactor: create helper function RelayRecoveredSig inside peerman #6423

merged 2 commits into from
Nov 22, 2024

Commits on Nov 22, 2024

  1. refactor: create helper function RelayRecoveredSig inside peerman 

    this commit should have a few benefits:
1. previous logic using ForEachNode results in locking m_nodes_mutex, a highly contended RecursiveMutex, AND m_peer_mutex(in GetPeerRef)
2. prior also resulted in calling .find over the m_peer_map for each node. Basically old logic was (probably) O(n(nlogn) the new logic results in acquiring m_peer_mutex once and looping over the list of peers, (probably) O(n)
3. Moves networking logic out of llmq/ and into actual net_processing.cpp
    @PastaPastaPasta
    PastaPastaPasta committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4668db6 View commit details
    Browse the repository at this point in the history

  2. refactor: drop unused CConnman from CSigningManager

    @knst @PastaPastaPasta
    knst authored and PastaPastaPasta committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    86e92c3 View commit details
    Browse the repository at this point in the history