feat: add dak.zip_no_broadcast #567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
approved these changes
Jan 31, 2025
| @@ -468,7 +468,7 @@ def to_dataframe( | |||
| """ | |||
| import dask | |||
| from dask.dataframe import DataFrame as DaskDataFrame | |||
| from dask.dataframe.core import new_dd_object # type: ignore | |||
| from dask.dataframe.core import new_dd_object | |||
There was a problem hiding this comment.
This does not work with new dask, this is the problem that needs fixing. I don't know if that has any implication for this PR.
There was a problem hiding this comment.
my pre-commit did complain about this - ah maybe I was on an old dask version locally?
There was a problem hiding this comment.
I suppose it's fine either way, we know this code is OK on python 3.9 (which never got the new dask) and doesn't work on newer versions at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awkward-array v2.7.4 introduces
ak.zip_no_broadcastwhich is useful for coffea to construct arrays without touching unwanted buffer keys. This PR implements thedakequivalent.