Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer explicitly set imagePullPolicy to IfNotPresent by default #770

Merged
merged 1 commit into from
Nov 17, 2023
Merged

No longer explicitly set imagePullPolicy to IfNotPresent by default #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dask-gateway-server/dask_gateway_server/backends/kubernetes/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def _default_namespace(self):
)

image_pull_policy = Unicode(
"IfNotPresent",
None,
allow_none=True,
help="The image pull policy of the docker image specified in ``image``",
config=True,
)
Expand Down
3 changes: 2 additions & 1 deletion dask-gateway-server/dask_gateway_server/backends/kubernetes/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@ def make_pod(self, namespace, cluster_name, config, is_worker=False):
"image": config.image,
"args": cmd,
"env": env,
"imagePullPolicy": config.image_pull_policy,
"resources": {
"requests": {"cpu": f"{cpu_req:.3f}", "memory": str(mem_req)},
"limits": {"cpu": f"{cpu_lim:.3f}", "memory": str(mem_lim)},
Expand All @@ -1155,6 +1154,8 @@ def make_pod(self, namespace, cluster_name, config, is_worker=False):
{"name": "api", "containerPort": 8788},
],
}
if config.image_pull_policy:
container["imagePullPolicy"] = config.image_pull_policy

container.update(probes)

Expand Down
8 changes: 4 additions & 4 deletions resources/helm/dask-gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ gateway:
image:
name: ghcr.io/dask/dask-gateway-server
tag: "set-by-chartpress"
pullPolicy: IfNotPresent
pullPolicy:

# Add additional environment variables to the gateway pod
# e.g.
Expand Down Expand Up @@ -122,7 +122,7 @@ gateway:
image:
name: ghcr.io/dask/dask-gateway
tag: "set-by-chartpress"
pullPolicy: IfNotPresent
pullPolicy:

# Image pull secrets for a dask cluster's scheduler and worker pods
imagePullSecrets: []
Expand Down Expand Up @@ -221,7 +221,7 @@ controller:
image:
name: ghcr.io/dask/dask-gateway-server
tag: "set-by-chartpress"
pullPolicy: IfNotPresent
pullPolicy:

# Settings for nodeSelector, affinity, and tolerations for the controller pods
nodeSelector: {}
Expand All @@ -247,7 +247,7 @@ traefik:
image:
name: traefik
tag: "2.10.4"
pullPolicy: IfNotPresent
pullPolicy:
imagePullSecrets: []

# Any additional arguments to forward to traefik
Expand Down
Loading