-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(DMVP-1806): In api-gateway module resolve checkov errors #274
base: main
Are you sure you want to change the base?
Conversation
Output[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed |
Output2 issue(s) found:
Warning: local.account_id is declared but not used (terraform_unused_declarations)
on bucket.tf line 10:
10: account_id = var.account_id == "" ? data.aws_caller_identity.current.account_id : var.account_id
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "alb_log_bucket_prefix" is declared but not used (terraform_unused_declarations)
on variables.tf line 16:
16: variable "alb_log_bucket_prefix" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "archive" in "required_providers" (terraform_required_providers)
on main.tf line 69:
69: data "archive_file" "this" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 42:
42: resource "aws_iam_role_policy" "cloudwatch" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 20:
20: resource "aws_iam_user_policy" "iam_user_policy" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output3 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "helm" in "required_providers" (terraform_required_providers)
on main.tf line 3:
3: resource "helm_release" "aws-cloudwatch-metrics" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on role.tf line 37:
37: resource "aws_iam_role_policy_attachment" "CloudWatchAgentServerPolicy" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output4 issue(s) found:
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 151:
151: module "custom_domain" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 7:
7: value = aws_api_gateway_rest_api.this.*.execution_arn
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: `monitoring_settings` variable has no type (terraform_typed_variables)
on variables.tf line 94:
94: variable "monitoring_settings" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: variable "create_cloudwatch_log_role" is declared but not used (terraform_unused_declarations)
on variables.tf line 130:
130: variable "create_cloudwatch_log_role" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output1 issue(s) found:
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 83:
83: resource "aws_ec2_client_vpn_route" "my-vpn_sso" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output |
Output6 issue(s) found:
Warning: local.this_region is declared but not used (terraform_unused_declarations)
on locals.tf line 2:
2: this_region = data.aws_region.this.name
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: local.peer_region is declared but not used (terraform_unused_declarations)
on locals.tf line 3:
3: peer_region = data.aws_region.peer.name
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 56:
56: value = tolist(aws_route.this_routes.*)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 61:
61: value = tolist(aws_route.peer_routes.*)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: variable "aws_this" is declared but not used (terraform_unused_declarations)
on variables.tf line 101:
101: variable "aws_this" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "aws_peer" is declared but not used (terraform_unused_declarations)
on variables.tf line 106:
106: variable "aws_peer" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output3 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "random" in "required_providers" (terraform_required_providers)
on main.tf line 1:
1: resource "random_password" "password" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on security-group.tf line 5:
5: resource "aws_security_group" "sg" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output11 issue(s) found:
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 3:
3: value = element(concat(aws_cloudfront_distribution.this.*.id, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 8:
8: value = element(concat(aws_cloudfront_distribution.this.*.arn, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 13:
13: value = element(concat(aws_cloudfront_distribution.this.*.caller_reference, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 18:
18: value = element(concat(aws_cloudfront_distribution.this.*.status, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 23:
23: value = element(concat(aws_cloudfront_distribution.this.*.trusted_signers, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 28:
28: value = element(concat(aws_cloudfront_distribution.this.*.domain_name, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 33:
33: value = element(concat(aws_cloudfront_distribution.this.*.last_modified_time, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 38:
38: value = element(concat(aws_cloudfront_distribution.this.*.in_progress_validation_batches, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 43:
43: value = element(concat(aws_cloudfront_distribution.this.*.etag, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 48:
48: value = element(concat(aws_cloudfront_distribution.this.*.hosted_zone_id, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on outputs.tf line 68:
68: value = element(concat(aws_cloudfront_monitoring_subscription.this.*.id, [""]), 0)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 43:
43: resource "aws_s3_bucket_policy" "s3" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output3 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on dashboard.tf line 1:
1: resource "aws_cloudwatch_dashboard" "applications" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: `widgets` variable has no type (terraform_typed_variables)
on variables.tf line 7:
7: variable "widgets" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md |
Output |
1 similar comment
Output |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 14:
14: resource "aws_cloudwatch_log_group" "log_group" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on pool.tf line 6:
6: resource "aws_cognito_identity_pool" "main" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on user-pool.tf line 1:
1: resource "aws_cognito_user_pool" "user-pool" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output6 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on pool.tf line 1:
1: resource "aws_cognito_user_pool" "pool" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: `recovery_mechanism` variable has no type (terraform_typed_variables)
on variables.tf line 79:
79: variable "recovery_mechanism" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `invite_message_template` variable has no type (terraform_typed_variables)
on variables.tf line 93:
93: variable "invite_message_template" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `lambda_config` variable has no type (terraform_typed_variables)
on variables.tf line 114:
114: variable "lambda_config" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `schema` variable has no type (terraform_typed_variables)
on variables.tf line 125:
125: variable "schema" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md |
Output3 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on roles-attachment.tf line 1:
1: resource "aws_cognito_identity_pool_roles_attachment" "attachment" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: `cognito_identity_providers` variable has no type (terraform_typed_variables)
on variables.tf line 38:
38: variable "cognito_identity_providers" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md |
Output |
Output1 issue(s) found:
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on main.tf line 28:
28: security_group_ids = aws_security_group.elastic_search_sg.*.id
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md |
Output3 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 54:
54: resource "aws_iam_policy_attachment" "test-attach" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "kubernetes" in "required_providers" (terraform_required_providers)
on main.tf line 103:
103: resource "kubernetes_namespace" "namespace" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output3 issue(s) found:
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on output.tf line 17:
17: value = try(data.kubernetes_ingress_v1.ingress.status.0.load_balancer.0.ingress.0.hostname, null)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on output.tf line 17:
17: value = try(data.kubernetes_ingress_v1.ingress.status.0.load_balancer.0.ingress.0.hostname, null)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md
Warning: List items should be accessed using square brackets (terraform_deprecated_index)
on output.tf line 17:
17: value = try(data.kubernetes_ingress_v1.ingress.status.0.load_balancer.0.ingress.0.hostname, null)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_index.md |
Output9 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 2:
2: auth = jsonencode({ "userPoolARN" = "${var.auth.userPoolARN}", "userPoolClientID" = "${var.auth.userPoolClientID}", "userPoolDomain" = "${var.auth.userPoolDomain}" })
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 2:
2: auth = jsonencode({ "userPoolARN" = "${var.auth.userPoolARN}", "userPoolClientID" = "${var.auth.userPoolClientID}", "userPoolDomain" = "${var.auth.userPoolDomain}" })
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 2:
2: auth = jsonencode({ "userPoolARN" = "${var.auth.userPoolARN}", "userPoolClientID" = "${var.auth.userPoolClientID}", "userPoolDomain" = "${var.auth.userPoolDomain}" })
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Missing version constraint for provider "kubernetes" in "required_providers" (terraform_required_providers)
on main.tf line 22:
22: resource "kubernetes_manifest" "create_namespace" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "null" in "required_providers" (terraform_required_providers)
on main.tf line 33:
33: resource "null_resource" "vpa_configure" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "helm" in "required_providers" (terraform_required_providers)
on main.tf line 44:
44: resource "helm_release" "goldilocks_deploy" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: variable "zone_name" is declared but not used (terraform_unused_declarations)
on varables.tf line 19:
19: variable "zone_name" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "alb_subnet" is declared but not used (terraform_unused_declarations)
on varables.tf line 46:
46: variable "alb_subnet" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 1:
1: resource "aws_iam_account_password_policy" "this" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output |
Output |
1 similar comment
Output |
Output9 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 2:
2: auth = jsonencode({ "userPoolARN" = "${var.auth.userPoolARN}", "userPoolClientID" = "${var.auth.userPoolClientID}", "userPoolDomain" = "${var.auth.userPoolDomain}" })
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 2:
2: auth = jsonencode({ "userPoolARN" = "${var.auth.userPoolARN}", "userPoolClientID" = "${var.auth.userPoolClientID}", "userPoolDomain" = "${var.auth.userPoolDomain}" })
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 2:
2: auth = jsonencode({ "userPoolARN" = "${var.auth.userPoolARN}", "userPoolClientID" = "${var.auth.userPoolClientID}", "userPoolDomain" = "${var.auth.userPoolDomain}" })
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Missing version constraint for provider "kubernetes" in "required_providers" (terraform_required_providers)
on main.tf line 22:
22: resource "kubernetes_manifest" "create_namespace" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "null" in "required_providers" (terraform_required_providers)
on main.tf line 33:
33: resource "null_resource" "vpa_configure" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: Missing version constraint for provider "helm" in "required_providers" (terraform_required_providers)
on main.tf line 44:
44: resource "helm_release" "goldilocks_deploy" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: variable "zone_name" is declared but not used (terraform_unused_declarations)
on varables.tf line 19:
19: variable "zone_name" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "alb_subnet" is declared but not used (terraform_unused_declarations)
on varables.tf line 46:
46: variable "alb_subnet" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output7 issue(s) found:
Warning: Missing version constraint for provider "random" in "required_providers" (terraform_required_providers)
on users.tf line 1:
1: resource "random_password" "password" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md
Warning: `users` variable has no type (terraform_typed_variables)
on variables.tf line 12:
12: variable "users" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `policy_item_hourly` variable has no type (terraform_typed_variables)
on variables.tf line 167:
167: variable "policy_item_hourly" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `policy_item_daily` variable has no type (terraform_typed_variables)
on variables.tf line 176:
176: variable "policy_item_daily" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `policy_item_weekly` variable has no type (terraform_typed_variables)
on variables.tf line 184:
184: variable "policy_item_weekly" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `policy_item_monthly` variable has no type (terraform_typed_variables)
on variables.tf line 192:
192: variable "policy_item_monthly" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `audit_filter` variable has no type (terraform_typed_variables)
on variables.tf line 236:
236: variable "audit_filter" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 76:
76: resource "aws_iam_group_membership" "this" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on secret.tf line 5:
5: resource "aws_secretsmanager_secret_version" "value" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 14:
14: resource "aws_route53_record" "add_record" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output3 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: variable "grant" is declared but not used (terraform_unused_declarations)
on variables.tf line 36:
36: variable "grant" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "owner" is declared but not used (terraform_unused_declarations)
on variables.tf line 42:
42: variable "owner" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output7 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 105:
105: memory_dashboard = var.enable_memory_threshold ? "${var.enable_cpu_threshold ? local.add_comma_memory : local.memory}" : local.null
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 108:
108: network_dashboard = var.enable_network_threshold ? "${var.enable_memory_threshold ? local.add_comma_network : "${var.enable_cpu_threshold ? local.add_comma_network : local.network}"}" : local.null
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 108:
108: network_dashboard = var.enable_network_threshold ? "${var.enable_memory_threshold ? local.add_comma_network : "${var.enable_cpu_threshold ? local.add_comma_network : local.network}"}" : local.null
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 111:
111: restart_dashboard = var.enable_restart_threshold ? "${var.enable_network_threshold ? local.add_comma_restart : var.enable_memory_threshold ? local.add_comma_restart : var.enable_cpu_threshold ? local.add_comma_restart : local.restart}" : local.null
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on main.tf line 114:
114: error_dashboard = var.enable_error_filter ? "${var.enable_restart_threshold ? local.add_comma_error : var.enable_network_threshold ? local.add_comma_error : var.enable_memory_threshold ? local.add_comma_error : var.enable_cpu_threshold ? local.add_comma_error : local.error}" : local.null
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_deprecated_interpolation.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 132:
132: resource "aws_cloudwatch_dashboard" "error_metric_include2" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output10 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: variable "alarm_region" is declared but not used (terraform_unused_declarations)
on variables.tf line 31:
31: variable "alarm_region" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: `tags` variable has no type (terraform_typed_variables)
on variables.tf line 61:
61: variable "tags" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: `dimensions` variable has no type (terraform_typed_variables)
on variables.tf line 114:
114: variable "dimensions" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: variable "dimensions" is declared but not used (terraform_unused_declarations)
on variables.tf line 114:
114: variable "dimensions" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "alarm_actions" is declared but not used (terraform_unused_declarations)
on variables.tf line 139:
139: variable "alarm_actions" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: `depends` variable has no type (terraform_typed_variables)
on variables.tf line 149:
149: variable "depends" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_typed_variables.md
Warning: variable "depends" is declared but not used (terraform_unused_declarations)
on variables.tf line 149:
149: variable "depends" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "topic_name" is declared but not used (terraform_unused_declarations)
on variables.tf line 161:
161: variable "topic_name" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md
Warning: variable "sms_message_body" is declared but not used (terraform_unused_declarations)
on variables.tf line 179:
179: variable "sms_message_body" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_unused_declarations.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on data.tf line 2:
2: data "aws_region" "current" {}
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on certificates.tf line 42:
42: resource "aws_route53_record" "main" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output2 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md
Warning: Missing version constraint for provider "aws" in "required_providers" (terraform_required_providers)
on main.tf line 40:
40: resource "aws_wafv2_ip_set" "whitelist_ip_set" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_providers.md |
Output1 issue(s) found:
Warning: terraform "required_version" attribute is required (terraform_required_version)
on line 0:
(source code not available)
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md |
Output |
Outputcheck for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed |
…-vpnendpoint module errors
…-to-cloudwatch, iam-account-password policy, secret, sns-cronjob, vpc-flow-logs-to-s3-to-cloudwatch module errors
description = "(Optional) Transport Layer Security (TLS) version + cipher suite for this DomainName. Valid values are TLS_1_0 and TLS_1_2. Must be configured to perform drift detection." | ||
} | ||
|
||
variable "enabled" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check and remove this non in use variable
@@ -42,7 +42,8 @@ data "aws_iam_policy_document" "execution_role" { | |||
sid = "AllowCloudWatchLogs" | |||
actions = [ | |||
"logs:CreateLogGroup", | |||
"logs:CreateLogStream", | |||
"logs:Cre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line is still broken
} | ||
} | ||
|
||
resource "aws_s3_bucket_public_access_block" "access" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the users pass these "true" values dynamically and not have it hardcoded here. Also, you can set "true" the default values for those variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no special need to have this options controller from outside as this access is for blocking public access to bucket always,
we have to decide and test to make sure this is ok, as I see this bucket should be accessible to write and read from lambda and cloudwatch and this services should be able to get access to do those actions?
@@ -4,9 +4,10 @@ data "aws_s3_bucket" "selected" { | |||
} | |||
|
|||
resource "aws_cloudwatch_log_group" "log" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest deleting this module from the repo, cause it's already exists in eks module.
deployment_id = aws_api_gateway_deployment.deployment.id | ||
rest_api_id = aws_api_gateway_rest_api.this.id | ||
xray_tracing_enabled = var.xray_tracing_enabled | ||
cache_cluster_enabled = var.cache_cluster_enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be better to have a map of these 2 variables.
description = "sse_algorithm - (Required) The server-side encryption algorithm to use. Valid values are AES256 and aws:kms" | ||
} | ||
|
||
variable "enabled" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name and description of variable is not descriptive,
at one look one can think that this option controls whether alb-log-to-s3-to-cloudwatch is enabled, but actually seems it just enables versioning on logs bucket,
please have descriptive name/descriptions for variables
} | ||
} | ||
|
||
resource "aws_s3_bucket_public_access_block" "access" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no special need to have this options controller from outside as this access is for blocking public access to bucket always,
we have to decide and test to make sure this is ok, as I see this bucket should be accessible to write and read from lambda and cloudwatch and this services should be able to get access to do those actions?
@@ -42,7 +42,8 @@ data "aws_iam_policy_document" "execution_role" { | |||
sid = "AllowCloudWatchLogs" | |||
actions = [ | |||
"logs:CreateLogGroup", | |||
"logs:CreateLogStream", | |||
"logs:Cre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line is still broken
reserved_concurrent_executions = 100 | ||
tracing_config { | ||
mode = "Active" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have reserved_concurrent_executions and tracing_config configurable from variables and use defaults with empty values as not always we need reserved concurrency and not always we need tracing be active
@@ -9,6 +9,33 @@ resource "aws_s3_bucket" "bucket" { | |||
count = var.create_bucket ? 1 : 0 | |||
|
|||
bucket = local.bucket_name | |||
versioning { | |||
enabled = var.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same issue here related to non descriptive values,
lets have group of configs, something like
s3_bucket_options = {
versioning_enabled =optional(string, false)
logging= optional(list(any), [])
...
}
} | ||
|
||
dynamic "logging" { | ||
for_each = var.logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -38,6 +39,33 @@ resource "aws_s3_bucket" "s3" { | |||
count = var.create_s3_bucket ? 1 : 0 | |||
bucket = local.s3_bucket_name | |||
force_destroy = true | |||
versioning { | |||
enabled = var.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
server_side_encryption_configuration { | ||
rule { | ||
apply_server_side_encryption_by_default { | ||
sse_algorithm = var.sse_algorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -18,3 +18,21 @@ variable "assume_role_arn" { | |||
description = "AWS Acounts Assume roles arn which access bucket write" | |||
default = ["arn:aws:iam::*:role/eks-cluster-fluent-bit-role"] | |||
} | |||
|
|||
variable "sse_algorithm" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here for this 3 variables
description = "sse_algorithm - (Required) The server-side encryption algorithm to use. Valid values are AES256 and aws:kms" | ||
} | ||
|
||
variable "enabled" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
No description provided.