Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMVP-6480): ProxySQL setup on RDS #21

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix(DMVP-6480): ProxySQL setup on RDS #21

merged 3 commits into from
Jan 21, 2025

Conversation

aghamyan44
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jan 21, 2025

PR Summary

  • Implemented Configuration for ProxySQL: A new configuration setup for ProxySQL has been added in main.tf. This setup clearly defines a Helm release and Kubernetes namespace, streamlining the deployment.
  • Established Basic Testing for ProxySQL Module: Basic testing procedures have been put in place using the tests/basic/main.tf. These tests utilize the previously mentioned ProxySQL setup and a sample configuration to ensure everything performs as intended.
  • Incorporated Support for AWS EKS Provider: The ability to operate on AWS EKS (Amazon's Elastic Kubernetes Service) has been added in tests/basic/provider.tf. This inclusion allows compatibility with Kubernetes and Helm within Amazon's cloud infrastructure, expanding the usable platforms.
  • Input Configuration File — values.yaml: A new file, values.yaml, has been introduced to house various parameters needed for configuring ProxySQL. This file will include important settings such as the admin and MySQL user configurations.
  • Defined Essential Variables: A designated variables.tf has been added to clearly define module elements for configuring ProxySQL and MySQL, keeping things well organized for easier troubleshooting or modifications later on.
  • Specified Terraform and Provider Versions: A new file, version.tf, has been included to mandate the required versions of Terraform and the associated providers (AWS, Helm, and Kubernetes). This ensures the compatibility and stability of our infrastructure setup.

Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check that executables have shebangs.....................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

mrdntgrn
mrdntgrn previously approved these changes Jan 21, 2025
Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing modules/proxysql/README.md

check yaml...............................................................Passed
check that executables have shebangs.....................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

@aghamyan44 aghamyan44 merged commit af576e0 into main Jan 21, 2025
9 checks passed
@aghamyan44 aghamyan44 deleted the DMVP-6480 branch January 21, 2025 21:17
Copy link

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing modules/proxysql/README.md

check yaml...............................................................Passed
check that executables have shebangs.....................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants