Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmvp-6480 proxysql submodule improvements #23

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

mrdntgrn
Copy link
Contributor

@mrdntgrn mrdntgrn commented Feb 4, 2025

No description provided.

@mrdntgrn mrdntgrn changed the title Fix/dmvp 6480 proxysql submodule improvements dmvp-6480 proxysql submodule improvements Feb 4, 2025
Copy link

what-the-diff bot commented Feb 4, 2025

PR Summary

  • Improvements in Documentation
    The 'README.md' file has been updated to include sections about limitations and configurations specific to ProxySQL. This offers better clarity for users on how to use and configure the software.

  • Module Source Change
    The path from which the RDS AWS ProxySQL module is sourced has been modified from a relative path to a specific path, providing accurate access to the module, irrespective of the file's execution location.

  • MySQL Configuration Structure Update
    The structure of 'mysql_config' has been changed to define attributes like 'version', 'servers', and 'users' instead of specific connection parameters. This simplification enhances readability and manageability of database connections.

  • Consolidation of Configuration Management
    The 'values.yaml' file has been removed, streamlining all configuration management to inline specification, thereby centralizing configuration settings and simplifying adjustments.

  • Main Terraform File Update
    The 'main.tf' file has been revised to integrate the new configuration schema and merge default configurations using a fresh module. This overhaul helps to maintain clean, organized configurations, easing readability and modifications.

  • Additional Variables for Chart Versioning and Configurations
    New variables have been added in 'variables.tf' to accommodate chart versioning and further configuration options for ProxySQL and MySQL. This adds flexibility for users in customization and tracking version history.

  • Increase in Minimum Required Terraform Version
    The minimum version of Terraform required to run this software has been raised to 1.3.0, guaranteeing the use of features and fixes available in this or later versions.

  • Adjustment in Dependency Versions
    The versions for Helm and Kubernetes providers have been updated for compatibility. This adjustment ensures that these services operate efficiently and without conflicts when used in conjunction with the latest version of this software.

Copy link

github-actions bot commented Feb 4, 2025

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check that executables have shebangs.....................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

Copy link
Contributor

@aramkarapetian aramkarapetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrdntgrn mrdntgrn merged commit 6765a8a into main Feb 5, 2025
9 checks passed
@mrdntgrn mrdntgrn deleted the fix/DMVP-6480-proxysql-submodule-improvements branch February 5, 2025 06:57
Copy link

github-actions bot commented Feb 5, 2025

🎉 This PR is included in version 1.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 5, 2025

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check that executables have shebangs.....................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants