More tests on the API #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Made a couple of minor comments. Would love to know your thoughts.
Thanks! @iskode
rgommers
reviewed
Aug 23, 2021
There was a problem hiding this comment.
Thanks @iskode. Modulo naming things, I think this test approach does make sense. The assert_frame_equal checks are more comprehensive, however a separate check that the structure of the object created by __dataframe__() is correct is useful.
|
I've found some issues with testing the buffer in case of categorical variables. Commented codes in the function |
rgommers
reviewed
Aug 24, 2021
rgommers
reviewed
Aug 24, 2021
rgommers
reviewed
Aug 24, 2021
update with recent merges.
|
I've updated tests with recent merged PRs. |
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current tests focus on
from_dataframemethod. To have a better test coverage, I've written some test cases for__dataframe__method. Note that this is a starting point. Added tests are not complete e.gBuffertests are missing.