Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: anonymous posts #44

Merged
merged 6 commits into from
Mar 11, 2024
Merged

add: anonymous posts #44

merged 6 commits into from
Mar 11, 2024

Conversation

puigde
Copy link
Contributor

@puigde puigde commented Mar 10, 2024

Implementa #42. Pendent de mirar tema build perquè fa canvis a l'esquema post-migració.

Copy link

tidb-cloud-branching bot commented Mar 10, 2024

The latest updates on TiDB Serverless Branch. Learn more about branching GitHub integration↗︎

BranchName ClusterID Status Updated
anonymousPosts_44_469bcea 10034588272270804309 ACTIVE 2024-03-10T23:40:39Z

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apunts-dades ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 11:41pm

@puigde
Copy link
Contributor Author

puigde commented Mar 10, 2024

sembla que també he canviat part de formatting (per això surten tantes línies de codi) potser estaria bé definir un autoformatter en un pre-commit hook.

@puigde
Copy link
Contributor Author

puigde commented Mar 10, 2024

la PR és un merder i té bastants errors, quan estigui arreglada i tingui el tema del formatting vist la trec de draft.

@puigde puigde requested a review from PauMatas March 10, 2024 23:40
@puigde puigde self-assigned this Mar 10, 2024
@puigde puigde marked this pull request as ready for review March 10, 2024 23:41
@puigde
Copy link
Contributor Author

puigde commented Mar 10, 2024

dinousaur on the chat 🦖🦖 @PauMatas

@puigde
Copy link
Contributor Author

puigde commented Mar 10, 2024

should handle this #45

Copy link
Member

@PauMatas PauMatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🧹
PS: mai més reformatejem un projecte amb més de 20 fitxers
PS2: Molt ben vist el donar el vscode config jeje

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@puigde puigde merged commit 814b570 into main Mar 11, 2024
4 checks passed
@puigde puigde deleted the anonymousPosts branch March 11, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants