Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afegir operador ternari per verificar si answers es null #56

Merged

Conversation

marcfranquesa
Copy link
Member

@marcfranquesa marcfranquesa commented Mar 11, 2024

@PauMatas

Si veus millor afegir variables ho faig, lo més guarro és el ternari dins el if

@marcfranquesa marcfranquesa requested a review from PauMatas March 11, 2024 18:05
@marcfranquesa marcfranquesa linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link

tidb-cloud-branching bot commented Mar 11, 2024

The latest updates on TiDB Serverless Branch. Learn more about branching GitHub integration↗︎

BranchName ClusterID Status Updated
54-bug-evaluating-answerslength-when-answers-is-nu_56_81bce5c 10034588272270804309 ACTIVE 2024-03-12T07:10:52Z

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apunts-dades ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 7:11am

@PauMatas
Copy link
Member

Has comprovat que faci l'efecte?

@marcfranquesa
Copy link
Member Author

marcfranquesa commented Mar 11, 2024

He pogut reproduir l'error en local, ara sembla que està arreglat

@marcfranquesa marcfranquesa force-pushed the 54-bug-evaluating-answerslength-when-answers-is-null branch from c57d7dc to 9247223 Compare March 11, 2024 19:16
@puigde
Copy link
Contributor

puigde commented Mar 11, 2024

lgtm mersi!! @marcfranquesa podries aprofitar per eliminar el package-lock.json que s'ha creat a la PR anterior i assegurar que tens tots els packages funcionant via yarn please?

Copy link
Contributor

@puigde puigde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@puigde puigde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcfranquesa marcfranquesa merged commit 6883de3 into main Mar 12, 2024
4 checks passed
@marcfranquesa marcfranquesa deleted the 54-bug-evaluating-answerslength-when-answers-is-null branch March 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: evaluating answers.length when answers is null
3 participants