Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55 refresh after submit #70

Merged
merged 2 commits into from
Mar 16, 2024
Merged

55 refresh after submit #70

merged 2 commits into from
Mar 16, 2024

Conversation

PauMatas
Copy link
Member

Dos pajaros de un tiro bby

During the fix I have also restyled a little bit the Editor interface so the title can use the placeholder instead of having placed text.
@PauMatas PauMatas requested a review from puigde March 15, 2024 13:37
@PauMatas PauMatas linked an issue Mar 15, 2024 that may be closed by this pull request
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
apunts-dades ✅ Ready (Inspect) Visit Preview Mar 15, 2024 1:37pm

@PauMatas PauMatas linked an issue Mar 15, 2024 that may be closed by this pull request
@marcfranquesa
Copy link
Member

ja em diras com fer que funcioni el link en un commit

@PauMatas
Copy link
Member Author

ja em diras com fer que funcioni el link en un commit

jajajajaj ni idea, jo el vaig ficar tal qual

@@ -158,22 +169,26 @@ const Editor: FC<EditorProps> = ({ subjectId, contentType, questionId }) => {
const questionId = data as string
const newPathname = pathname.replace("/q", `/q/${questionId}`)
router.push(newPathname)
router.refresh()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suposo que això és el punt que soluciona el tema refresh i lu altre és cleanup? Molt nice no sabia que es feia així

@puigde puigde merged commit 47fad16 into main Mar 16, 2024
3 checks passed
@puigde puigde deleted the 55-refresh-after-submit branch March 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: al compartir un comentari no refresca la web bug: treure titol default cutre de pregunta
3 participants