Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afegir selector any al pujar apunts #71

Conversation

marcfranquesa
Copy link
Member

Primera PR amb pes, fúnenme

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apunts-dades ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2024 7:38pm

@marcfranquesa marcfranquesa force-pushed the 43-feature-possibilitat-de-indicar-lany-que-has-cursat-lassignatura branch from 41092f9 to 737d36b Compare March 15, 2024 18:54
@marcfranquesa
Copy link
Member Author

mmm maybe estaria bé tenir-ho 2021/2022 en comptes de 2021

@marcfranquesa marcfranquesa force-pushed the 43-feature-possibilitat-de-indicar-lany-que-has-cursat-lassignatura branch from 737d36b to e63418f Compare March 15, 2024 18:58
Copy link
Member

@PauMatas PauMatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La resta lgtm

src/app/[slug]/submit/page.tsx Outdated Show resolved Hide resolved
src/components/Form.tsx Outdated Show resolved Hide resolved
@marcfranquesa marcfranquesa requested a review from PauMatas March 16, 2024 19:24
Copy link
Member

@PauMatas PauMatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecte!

En algun moment hauriem de mirar de fer que onChange del selector d'assignatura canvii l'any però m'ho he mirat per sobre i fa una mica de pal. Per altra banda estaria bé ficar els dropdowns un al costat de l'altre aixi ens queda un forms mes compacte pero de nou això ja serà una altra PR.

Bona canço btw 👷🏼‍♀️🏗️

@marcfranquesa marcfranquesa force-pushed the 43-feature-possibilitat-de-indicar-lany-que-has-cursat-lassignatura branch from 39d7634 to ab4deaa Compare March 16, 2024 19:37
@marcfranquesa marcfranquesa merged commit f963efd into main Mar 16, 2024
3 checks passed
@marcfranquesa marcfranquesa deleted the 43-feature-possibilitat-de-indicar-lany-que-has-cursat-lassignatura branch March 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: possibilitat de indicar l'any que has cursat l'assignatura
2 participants