-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getDatabaseMajorVersion & getDatabaseMinorVersion #228
Conversation
@rad-pat Thanks for your contribution. How about adding some unit tests for the modified function? |
@hantmac, I can try. It looked like it was partially covered by a test already, but now I can see why that was incorrectly passing (because it always matched the "-1" version to string "rust-1"). I've made the test more specific for the version. Hope it works, I cannot get the tests to run locally for some reason. |
Should be fixed now. It'd really help if I could run the tests, but the MetaData tests fail with this for me. I'm running against a locally installed Databend instance with user
|
@rad-pat Hi I add you to the github action CI, the CI will run auto when you push. |
a85c7dc
to
f5f2d90
Compare
@hantmac , thanks for that. It seems though that the test setup is a little flaky. I think that if this now ran, it would be successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Just match RegEx in Full string "Databend Query vx.y.zzz" or "DatabendQuery vx.y.zzz"
Fixes #204