Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rout hint policy in transaction #277

Closed
wants to merge 1 commit into from
Closed

fix: rout hint policy in transaction #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion databend-jdbc/src/main/java/com/databend/jdbc/DatabendConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ DatabendClient startQueryWithFailover(String sql, StageAttachment attach) throws
// 3. if there is not active transaction, it will use load balancing policy to choose a host to execute query
String query_id = UUID.randomUUID().toString();
String candidateHost = this.driverUri.getUri(query_id).toString();
if (!inActiveTransaction()) {
if (inActiveTransaction()) {
this.routeHint = uriRouteHint(candidateHost);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动应该也有问题，会使 transaciton 的请求匀到其他节点上

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uriRouteHint will keep the routHint Id the same when in active transaction. So it will route to the same node.

}
// checkout the host to use from route hint
Expand Down
Loading