Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix for views back in system.tables #45

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Sep 12, 2024

Otherwise get duplicate rows - just experienced 🤦

@rad-pat
Copy link
Contributor Author

rad-pat commented Sep 12, 2024

Hmmm, I get no test errors running against Databend 1.2.635

@rad-pat
Copy link
Contributor Author

rad-pat commented Sep 13, 2024

Looks like setting format_null_as_str in database, default is 1, turned on. Not sure why you'd want to bring nulls back as a string NULL by default.

@BohuTANG BohuTANG requested a review from TCeason September 14, 2024 02:34
@hantmac
Copy link
Member

hantmac commented Sep 15, 2024

@rad-pat HI, the CI TEST failed, plz check it.

@rad-pat
Copy link
Contributor Author

rad-pat commented Sep 15, 2024

@hantmac I'm pretty sure it's the format_null_as_str setting. Is there any way this can be set to 0 on the test Databend instance provisioned for these CI tests? I can try to figure out how to do this from the pytest side before any tests run if required. Or, possibly a param on the connection string?

 * This is ugly, should be set global on the database or connection string
@rad-pat
Copy link
Contributor Author

rad-pat commented Sep 16, 2024

@hantmac @TCeason I've fixed the tests by forcing the format_null_as_str option on every connection. This doesn't seem like a good approach going forward. Ideally would like to pass the param on the connection string to the bendsql driver.

@rad-pat rad-pat requested a review from TCeason September 16, 2024 10:01
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hantmac hantmac merged commit 3b65a30 into databendlabs:main Sep 16, 2024
2 checks passed
@hantmac
Copy link
Member

hantmac commented Sep 16, 2024

@hantmac I'm pretty sure it's the format_null_as_str setting. Is there any way this can be set to 0 on the test Databend instance provisioned for these CI tests? I can try to figure out how to do this from the pytest side before any tests run if required. Or, possibly a param on the connection string?

@rad-pat Adding the format_null_as_str in connection params is a good choice. I will make it. Thanks for your PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants