optimize: optimize query system.tables when query single table

src/meta/app/src/principal/mod.rs

@@ -102,6 +102,7 @@ pub use user_defined_function::UserDefinedFunction;
 pub use user_grant::GrantEntry;
 pub use user_grant::GrantObject;
 pub use user_grant::UserGrantSet;
+pub use user_grant::SYSTEM_TABLES_ALLOW_LIST;
 pub use user_identity::UserIdentity;
 pub use user_info::UserInfo;
 pub use user_info::UserOption;

src/meta/app/src/principal/user_grant.rs

@@ -21,6 +21,33 @@ use enumflags2::BitFlags;
 use crate::principal::UserPrivilegeSet;
 use crate::principal::UserPrivilegeType;
 
+// some statements like `SELECT 1`, `SHOW USERS`, `SHOW ROLES`, `SHOW TABLES` will be
+// rewritten to the queries on the system tables, we need to skip the privilege check on
+// these tables.
+pub const SYSTEM_TABLES_ALLOW_LIST: [&str; 21] = [
+    "catalogs",
+    "columns",
+    "databases",
+    "databases_with_history",
+    "dictionaries",
+    "tables",
+    "views",
+    "tables_with_history",
+    "views_with_history",
+    "password_policies",
+    "streams",
+    "streams_terse",
+    "virtual_columns",
+    "users",
+    "roles",
+    "stages",
+    "one",
+    "processes",
+    "user_functions",
+    "functions",
+    "indexes",
+];
+
 #[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Eq, PartialEq, Hash)]
 pub enum GrantObject {
     Global,

src/query/catalog/src/table_context.rs

@@ -224,7 +224,10 @@ pub trait TableContext: Send + Sync {
         check_current_role_only: bool,
     ) -> Result<()>;
     async fn get_available_roles(&self) -> Result<Vec<RoleInfo>>;
-    async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker>;
+    async fn get_visibility_checker(
+        &self,
+        ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker>;
     fn get_fuse_version(&self) -> String;
     fn get_format_settings(&self) -> Result<FormatSettings>;
     fn get_tenant(&self) -> Tenant;

src/query/management/src/role/role_mgr.rs

@@ -211,6 +211,7 @@ impl RoleApi for RoleMgr {
     #[async_backtrace::framed]
     #[fastrace::trace]
     async fn get_ownerships(&self) -> Result<Vec<SeqV<OwnershipInfo>>, ErrorCode> {
+        println!("will call get_ownerships");
         let object_owner_prefix = self.ownership_object_prefix();
         let values = self
             .kv_api

src/query/service/src/interpreters/access/privilege_access.rs

@@ -29,6 +29,7 @@ use databend_common_meta_app::principal::StageType;
 use databend_common_meta_app::principal::UserGrantSet;
 use databend_common_meta_app::principal::UserPrivilegeSet;
 use databend_common_meta_app::principal::UserPrivilegeType;
+use databend_common_meta_app::principal::SYSTEM_TABLES_ALLOW_LIST;
 use databend_common_meta_app::tenant::Tenant;
 use databend_common_meta_types::seq_value::SeqV;
 use databend_common_sql::binder::MutationType;
@@ -58,33 +59,6 @@ enum ObjectId {
     Table(u64, u64),
 }
 
-// some statements like `SELECT 1`, `SHOW USERS`, `SHOW ROLES`, `SHOW TABLES` will be
-// rewritten to the queries on the system tables, we need to skip the privilege check on
-// these tables.
-const SYSTEM_TABLES_ALLOW_LIST: [&str; 21] = [
-    "catalogs",
-    "columns",
-    "databases",
-    "databases_with_history",
-    "dictionaries",
-    "tables",
-    "views",
-    "tables_with_history",
-    "views_with_history",
-    "password_policies",
-    "streams",
-    "streams_terse",
-    "virtual_columns",
-    "users",
-    "roles",
-    "stages",
-    "one",
-    "processes",
-    "user_functions",
-    "functions",
-    "indexes",
-];
-
 // table functions that need `Super` privilege
 const SYSTEM_TABLE_FUNCTIONS: [&str; 1] = ["fuse_amend"];
 

src/query/service/src/sessions/query_ctx.rs

@@ -692,8 +692,14 @@ impl TableContext for QueryContext {
         self.get_current_session().get_id()
     }
 
-    async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker> {
-        self.shared.session.get_visibility_checker().await
+    async fn get_visibility_checker(
+        &self,
+        ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker> {
+        self.shared
+            .session
+            .get_visibility_checker(ignore_ownership)
+            .await
     }
 
     fn get_fuse_version(&self) -> String {

src/query/service/src/sessions/session.rs

@@ -310,8 +310,13 @@ impl Session {
     }
 
     #[async_backtrace::framed]
-    pub async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker> {
-        self.privilege_mgr().get_visibility_checker().await
+    pub async fn get_visibility_checker(
+        &self,
+        ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker> {
+        self.privilege_mgr()
+            .get_visibility_checker(ignore_ownership)
+            .await
     }
 
     pub fn get_settings(&self) -> Arc<Settings> {

src/query/service/src/sessions/session_privilege_mgr.rs

@@ -75,7 +75,10 @@ pub trait SessionPrivilegeManager {
 
     async fn validate_available_role(&self, role_name: &str) -> Result<RoleInfo>;
 
-    async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker>;
+    async fn get_visibility_checker(
+        &self,
+        ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker>;
 
     // fn show_grants(&self);
 }
@@ -336,27 +339,31 @@ impl<'a> SessionPrivilegeManager for SessionPrivilegeManagerImpl<'a> {
     }
 
     #[async_backtrace::framed]
-    async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker> {
+    async fn get_visibility_checker(
+        &self,
+        ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker> {
         // TODO(liyz): is it check the visibility according onwerships?
-        let user_api = UserApiProvider::instance();
-        let ownerships = user_api
-            .role_api(&self.session_ctx.get_current_tenant())
-            .get_ownerships()
-            .await?;
         let roles = self.get_all_effective_roles().await?;
         let roles_name: Vec<String> = roles.iter().map(|role| role.name.to_string()).collect();
 
-        let ownership_objects = if roles_name.contains(&"account_admin".to_string()) {
-            vec![]
-        } else {
-            let mut ownership_objects = vec![];
-            for ownership in ownerships {
-                if roles_name.contains(&ownership.data.role) {
-                    ownership_objects.push(ownership.data.object);
+        let ownership_objects =
+            if roles_name.contains(&"account_admin".to_string()) || ignore_ownership {
+                vec![]
+            } else {
+                let user_api = UserApiProvider::instance();
+                let ownerships = user_api
+                    .role_api(&self.session_ctx.get_current_tenant())
+                    .get_ownerships()
+                    .await?;
+                let mut ownership_objects = vec![];
+                for ownership in ownerships {
+                    if roles_name.contains(&ownership.data.role) {
+                        ownership_objects.push(ownership.data.object);
+                    }
                 }
-            }
-            ownership_objects
-        };
+                ownership_objects
+            };
 
         Ok(GrantObjectVisibilityChecker::new(
             &self.get_current_user()?,

src/query/service/src/table_functions/infer_schema/parquet.rs

@@ -99,7 +99,7 @@ impl AsyncSource for ParquetInferSchemaSource {
             .get_settings()
             .get_enable_experimental_rbac_check()?;
         if enable_experimental_rbac_check {
-            let visibility_checker = self.ctx.get_visibility_checker().await?;
+            let visibility_checker = self.ctx.get_visibility_checker(false).await?;
             if !(stage_info.is_temporary
                 || visibility_checker.check_stage_read_visibility(&stage_info.stage_name)
                 || stage_info.stage_type == StageType::User

src/query/service/src/table_functions/inspect_parquet/inspect_parquet_table.rs

@@ -213,7 +213,7 @@ impl AsyncSource for InspectParquetSource {
             .get_settings()
             .get_enable_experimental_rbac_check()?;
         if enable_experimental_rbac_check {
-            let visibility_checker = self.ctx.get_visibility_checker().await?;
+            let visibility_checker = self.ctx.get_visibility_checker(false).await?;
             if !(stage_info.is_temporary
                 || visibility_checker.check_stage_read_visibility(&stage_info.stage_name)
                 || stage_info.stage_type == StageType::User

src/query/service/src/table_functions/list_stage/list_stage_table.rs

@@ -187,7 +187,7 @@ impl ListStagesSource {
             .get_settings()
             .get_enable_experimental_rbac_check()?;
         if enable_experimental_rbac_check {
-            let visibility_checker = self.ctx.get_visibility_checker().await?;
+            let visibility_checker = self.ctx.get_visibility_checker(false).await?;
             if !(stage_info.is_temporary
                 || visibility_checker.check_stage_read_visibility(&stage_info.stage_name)
                 || stage_info.stage_type == StageType::User

src/query/service/src/table_functions/show_grants/show_grants_table.rs

@@ -566,7 +566,7 @@ async fn show_object_grant(
     let tenant = ctx.get_tenant();
     let user_api = UserApiProvider::instance();
     let roles = user_api.get_roles(&tenant).await?;
-    let visibility_checker = ctx.get_visibility_checker().await?;
+    let visibility_checker = ctx.get_visibility_checker(false).await?;
     let current_user = ctx.get_current_user()?.identity().username;
     let (object, owner_object, object_id, object_name) = match grant_type {
         "table" => {

src/query/service/tests/it/sql/exec/get_table_bind_test.rs

@@ -690,7 +690,10 @@ impl TableContext for CtxDelegation {
         todo!()
     }
 
-    async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker> {
+    async fn get_visibility_checker(
+        &self,
+        _ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker> {
         todo!()
     }
 

src/query/service/tests/it/storages/fuse/operations/commit.rs

@@ -594,7 +594,10 @@ impl TableContext for CtxDelegation {
         todo!()
     }
 
-    async fn get_visibility_checker(&self) -> Result<GrantObjectVisibilityChecker> {
+    async fn get_visibility_checker(
+        &self,
+        _ignore_ownership: bool,
+    ) -> Result<GrantObjectVisibilityChecker> {
         todo!()
     }
 

src/query/storages/system/Cargo.toml

@@ -39,6 +39,7 @@ databend-common-storages-result-cache = { workspace = true }
 databend-common-storages-stream = { workspace = true }
 databend-common-storages-view = { workspace = true }
 databend-common-users = { workspace = true }
+databend-common-management = { workspace = true }
 databend-storages-common-cache = { workspace = true }
 futures = { workspace = true }
 itertools = { workspace = true }

src/query/storages/system/src/columns_table.rs

@@ -274,7 +274,7 @@ pub(crate) async fn dump_tables(
         }
     }
 
-    let visibility_checker = ctx.get_visibility_checker().await?;
+    let visibility_checker = ctx.get_visibility_checker(false).await?;
 
     let mut final_dbs: Vec<(String, u64)> = Vec::new();
 

src/query/storages/system/src/databases_table.rs

@@ -117,7 +117,7 @@ where DatabasesTable<WITH_HISTORY>: HistoryAware
         let mut owners: Vec<Option<String>> = vec![];
         let mut dropped_on: Vec<Option<i64>> = vec![];
 
-        let visibility_checker = ctx.get_visibility_checker().await?;
+        let visibility_checker = ctx.get_visibility_checker(false).await?;
         let catalog_dbs = visibility_checker.get_visibility_database();
         // None means has global level privileges
         if let Some(catalog_dbs) = catalog_dbs {

src/query/storages/system/src/indexes_table.rs

@@ -154,7 +154,7 @@ impl IndexesTable {
         ctx: Arc<dyn TableContext>,
     ) -> Result<Vec<TableInfo>> {
         let tenant = ctx.get_tenant();
-        let visibility_checker = ctx.get_visibility_checker().await?;
+        let visibility_checker = ctx.get_visibility_checker(false).await?;
         let catalog = ctx.get_catalog(CATALOG_DEFAULT).await?;
 
         let ctl_name = catalog.name();

src/query/storages/system/src/stages_table.rs

@@ -62,7 +62,7 @@ impl AsyncSystemTable for StagesTable {
         let enable_experimental_rbac_check =
             ctx.get_settings().get_enable_experimental_rbac_check()?;
         let stages = if enable_experimental_rbac_check {
-            let visibility_checker = ctx.get_visibility_checker().await?;
+            let visibility_checker = ctx.get_visibility_checker(false).await?;
             stages
                 .into_iter()
                 .filter(|stage| {

src/query/storages/system/src/streams_table.rs

@@ -80,7 +80,7 @@ impl<const T: bool> AsyncSystemTable for StreamsTable<T> {
             .iter()
             .map(|e| (e.name(), e.clone()))
             .collect::<Vec<_>>();
-        let visibility_checker = ctx.get_visibility_checker().await?;
+        let visibility_checker = ctx.get_visibility_checker(false).await?;
         let user_api = UserApiProvider::instance();
 
         let mut catalogs = vec![];