-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support asof join #15411
base: main
Are you sure you want to change the base?
feat: support asof join #15411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zenus
I think we don't need to ensure the order of results. It makes sense for different databases to have different results order.
I've skimmed through the code and there are a few points to note:
todo!()
needs to be replaced with code that makes sense or provides a specific error message.build_asof_join
method can be further split into smaller functions.- Regarding tests, if you are going to borrow the test set from duckdb, you can put the tests in the directory https://github.com/datafuselabs/databend/tree/main/tests/sqllogictests/suites/duckdb/asof_ join
- AsOf join can be used as an alternative to window to semantically express temporal relationships, if so, can you provide a performance comparison of asof join vs window?
In addition, I've opened a tracking issue on asof join, if you have time you can continue to finish some sub-issues in it.
nice advice , my pleasure. |
@Dousir9 could you help me , i can not pass all the case, in my laptop, i passed all new test case. |
@zenus Sorry for the wait, I was really busy, let's continue this excellent work.
|
@Dousir9 i have fixed the first and third , and for the second one i have no idea after i took a week to read the code. |
@xudong963 could you help me out ? |
Hi @zenus , sorry for the late reply, we've solved some issues in iejoin by now, could you please update your PR? |
/
ok |
JoinType::Asof | JoinType::LeftAsof | JoinType::RightAsof | ||
) && non_equi_conditions.is_empty() | ||
{ | ||
return Err(ErrorCode::SemanticError("Missing inequality condition!")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid Asof join, missing inequality condition
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Currently, due to different ways of implementing range join, the order of results obtained by asof join is random. I may be able to get help from @xudong963。that's why i do not add any test case.
Benchmark
build side : 5w probe side : 5w
Tests
Type of change
This change is