Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): db owner role can access all tables under this db #15634

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(query): db owner role can access all tables under this db #15634

merged 1 commit into from
May 29, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented May 24, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

db owner role can access all tables under this db.

If db owner drop the table that under db but not owned this role, the table's ownership also be revoked.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 24, 2024
@TCeason TCeason requested a review from flaneur2020 May 24, 2024 08:19
flaneur2020
flaneur2020 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCeason
Copy link
Collaborator Author

TCeason commented May 29, 2024

cc @wubx

@BohuTANG BohuTANG merged commit 7768d26 into databendlabs:main May 29, 2024
75 checks passed
TCeason added a commit to TCeason/databend-docs that referenced this pull request May 29, 2024
@TCeason
add database ownership note
4eaded9 
databendlabs/databend#15634
@TCeason TCeason mentioned this pull request May 29, 2024
Merged
BohuTANG pushed a commit to databendlabs/databend-docs that referenced this pull request Jun 2, 2024
@TCeason
add database ownership note (#817)
2f67d69 
databendlabs/databend#15634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaneur2020 flaneur2020 flaneur2020 approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: a db's owner should access all tables that under this db
3 participants
@TCeason @flaneur2020 @BohuTANG