Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add setting compact_max_block_selection #15641

Merged
merged 1 commit into from
May 25, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented May 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Key Features:

  1. Introduces the compact_max_block_selection setting.
  2. Ensures compact operations respect this limit, enhancing control over resource usage and performance.

This setting allows users to manage and optimize compact operations more effectively by preventing the selection of an excessive number of blocks.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 25, 2024
@zhyass zhyass requested review from BohuTANG and dantengsky May 25, 2024 14:50
@dantengsky dantengsky added this pull request to the merge queue May 25, 2024
Merged via the queue into databendlabs:main with commit a7bc773 May 25, 2024
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants