Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): refactor json functions #16840

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Nov 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor json functions

  • fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 14, 2024
Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Pointed the jsonb dependency to a new GitHub repository
    The change in the 'jsonb' resource location will ensure that our project is working with the latest, most stable version of this tool.

  • Introduced RawJsonb for variant JSON handling
    We've added a new way of managing the different forms of JSON we encounter in our project through RawJsonb. It improves the consistency and reliability of our JSON operations.

  • Adopted RawJsonb for JSON string conversion in multiple files
    Many parts of our code have now been updated to take advantage of RawJsonb for turning JSON into strings. This results in a more streamlined, unified approach to dealing with JSON.

  • Modified JSON serialization/deserialization to use RawJsonb
    Our methods for turning objects into JSON (serialization) and reading objects from JSON (deserialization) have been redesigned to make use of RawJsonb. This simplifies these processes and enhances their effectiveness.

  • **Replaced ‘jsonb::to_stringcalls withRawJsonbconversions** Direct calls to turn JSON into strings have now been switched withRawJsonb` conversions, enhancing clarity and encapsulating our approach for handling this task.

  • Overall benefits
    Overall, these changes help in streamlining our JSON handling operations, making them more consistent and type-safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant