Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Summary
The issue described in #16892, is caused by a read-after-use bug in the
opersrv
crate (ver 0.7).Description:
Valgrind identifies that, during the connection establishment between the MariaDB JDBC client and Databend's MySQL service, memory freed by
opensrv_mysql::packet_reader::PacketReader
is being accessed, leading to the failure of MySQL connection establishment (failed to process the input MySQL protocol command correctly).Resolution:
Fortunately, this issue has been fixed by @discord9 in PR #67. As a result, in this PR, the
opensrv
version used has been updated to commit#6cbb806
(andrustls
has been bumped to version0.23
to align with the version needed byopensrv
)Note:
To "reproduce" the following valgrind messages, Databend should be compiled using the standard memory allocator. Using the default
jemalloc
, valgrind can not detect any issues.Tests
Type of change
This change is