feat(functions): add jaro_winkler string similarity function #16993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
TCeason
reviewed
Dec 4, 2024
| @@ -841,6 +854,190 @@ pub(crate) mod soundex { | |||
| } | |||
| } | |||
|
|
|||
| // this implementation comes from https://github.com/joshuaclayton/jaro_winkler | |||
| pub(crate) mod jaro_winkler { | |||
There was a problem hiding this comment.
The function jaro_winkler and mod jaro_winkler can refactor to file other.rs.
TCeason
reviewed
Dec 4, 2024
|
|
||
| #[test] | ||
| fn different_is_zero() { | ||
| assert_eq!(jaro_winkler("foo", "bar"), 0.0); |
There was a problem hiding this comment.
maxjustus
force-pushed
the
string-distance
branch
from
0655e48 to
341939a
Compare
|
ok @TCeason - I've moved the definition to other.rs |
Please fmt code |
maxjustus
force-pushed
the
string-distance
branch
from
341939a to
a97f916
Compare
|
ok done @TCeason ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Adds a jaro_winkler string edit distance function taken from this project https://github.com/joshuaclayton/jaro_winkler
Tests
Type of change
This change is