Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rbac): add GrantObject::Warehouse #17029

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat(rbac): add GrantObject::Warehouse #17029

merged 1 commit into from
Dec 11, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Dec 11, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Warehouse permissions are granted to roles, and each warehouse can only be assigned to one role.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason requested a review from drmingdrmer as a code owner December 11, 2024 03:56
@TCeason TCeason marked this pull request as draft December 11, 2024 03:56
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 11, 2024
@TCeason TCeason requested a review from zhang2014 December 11, 2024 03:57
drmingdrmer
drmingdrmer approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 25 files at r1, all commit messages.
Reviewable status: 17 of 25 files reviewed, all discussions resolved (waiting on @zhang2014)

@TCeason TCeason force-pushed the warehouse_object branch 3 times, most recently from 6bd85a8 to 2c5a186 Compare December 11, 2024 10:38
@TCeason
feat(rbac): add GrantObject::Warehouse
4b0afe5 
Warehouse permissions are granted to roles, and each warehouse can only be assigned to one role.
@TCeason TCeason requested a review from flaneur2020 December 11, 2024 11:53
@TCeason TCeason marked this pull request as ready for review December 11, 2024 11:53
flaneur2020
flaneur2020 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BohuTANG BohuTANG merged commit 042f6f7 into databendlabs:main Dec 11, 2024
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@flaneur2020 flaneur2020 flaneur2020 approved these changes

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TCeason @drmingdrmer @flaneur2020 @zhang2014 @BohuTANG