Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tweak build_aggregate_partial #17038

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

tweak build_aggregate_partial: reduce data might be exchanged during partial aggregation (assuming no spilling needed)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - use existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 11, 2024
@dantengsky dantengsky requested a review from zhang2014 December 11, 2024 15:26
@dantengsky dantengsky marked this pull request as ready for review December 11, 2024 15:27
@dantengsky dantengsky force-pushed the release/v1.2.636-rc7-tweak-agg-exchange branch from c47ac17 to d51c5c0 Compare December 11, 2024 15:28
@dantengsky dantengsky requested a review from sundy-li December 11, 2024 15:28
@BohuTANG BohuTANG merged commit a32b80f into databendlabs:release/v1.2.636-rc7 Dec 12, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants