Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(input format): refactor with FieldEncoder. #8778

Merged
merged 14 commits into from
Nov 14, 2022

Conversation

youngsofun
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

part of #7732

@vercel
Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 14, 2022 at 7:28AM (UTC)

@youngsofun youngsofun mentioned this pull request Nov 13, 2022
58 tasks
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 13, 2022
@youngsofun youngsofun requested review from sundy-li and b41sh and removed request for sundy-li November 13, 2022 14:59
@youngsofun youngsofun requested a review from zhang2014 November 13, 2022 15:47
@youngsofun youngsofun force-pushed the ref branch 2 times, most recently from 172074f to c7109fb Compare November 14, 2022 03:39
@youngsofun youngsofun marked this pull request as draft November 14, 2022 05:05
@youngsofun youngsofun marked this pull request as ready for review November 14, 2022 05:18
@youngsofun
Copy link
Member Author

youngsofun commented Nov 14, 2022

not related to this pr

--- /workspace/tests/suites/0_stateless/13_tpch/13_0009_q9.result	2022-11-14 05:45:08.409161832 +0000
+++ /workspace/tests/suites/0_stateless/13_tpch/13_0009_q9.stdout	2022-11-14 05:48:52.606210366 +0000
@@ -1,5 +1 @@
-ALGERIA	1998	2321785.368
-ALGERIA	1997	3685016.858
-ALGERIA	1996	4276597.425
-ALGERIA	1995	4418370.415
-ALGERIA	1994	3864849.952
+ERROR 1105 (HY000) at line 2: result row write failed: Code: 1067, displayText = error reading a body from connection: broken pipe, source: Some(hyper::Error(Body, Error { kind: Io(Kind(BrokenPipe)) })).
ErrorType: statement query get result not equal to expected
Message: 
 Expected:
Query default                                                                   
 Actual:
Idle  default
Query  default                                        

Parsed Statement
    at_line: 1,
    s_type: Statement: query, type: TT, query_type: TT, retry: False,
    suite_name: base/03_dml/03_0011_select_from_system_processes,
    text:
        select command, database from system.processes;
    results: [(<re.Match object; span=(0, 4), match='----'>, 5, 'Query default')],
    runs_on: {'clickhouse', 'http', 'mysql'},
 Start Line: 5, Result Label: 
            

@youngsofun
Copy link
Member Author

youngsofun commented Nov 14, 2022

not related to this pr, and the error exists before the pr (also occur in other`s pr)

Runner: http
ErrorType: statement query execute with exception
Message: Failed to execute. Collected info: 1006: Unable to get field named "0". Valid fields: []

Parsed Statement
    at_line: 401,
    s_type: Statement: query, type: I, query_type: I, retry: False,
    suite_name: query/join.test,
    text:
        select * from (SELECT number AS a FROM numbers(10)) x right join (SELECT number AS a FROM numbers(5))  y using(a) order by x.a;
    results: [(<re.Match object; span=(0, 4), match='----'>, 409, '0\n1\n2\n3\n4')],
    runs_on: {'http', 'clickhouse', 'mysql'},

@youngsofun
Copy link
Member Author

youngsofun commented Nov 14, 2022

not related to this pr, and the error exists before the pr (also occur in other`s pr)

Runner: http
ErrorType: statement query execute with exception
Message: Failed to execute. Collected info: 1006: Unable to get field named "0". Valid fields: []

Parsed Statement
    at_line: 401,
    s_type: Statement: query, type: I, query_type: I, retry: False,
    suite_name: query/join.test,
    text:
        select * from (SELECT number AS a FROM numbers(10)) x right join (SELECT number AS a FROM numbers(5))  y using(a) order by x.a;
    results: [(<re.Match object; span=(0, 4), match='----'>, 409, '0\n1\n2\n3\n4')],
    runs_on: {'http', 'clickhouse', 'mysql'},

can we merge this pr mannualy @BohuTANG @Xuanwo

@Xuanwo Xuanwo merged commit b24be85 into databendlabs:main Nov 14, 2022
@youngsofun youngsofun deleted the ref branch November 16, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants