Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support workload type deployment #88

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Mar 29, 2024

Description:

This pull request introduces support for workload type deployment in the query component.

Changes:

  • Added support for workload type deployment in the .github/workflows/ci.yml file.
  • Modified configurations in charts/databend-meta/Chart.yaml and charts/databend-query/Chart.yaml.
  • Updated configurations in charts/databend-query/templates/configmap.yaml.
  • Added a new template file charts/databend-query/templates/deployment.yaml for deployment workload.
  • Modified charts/databend-query/templates/service.yaml and charts/databend-query/templates/statefulset.yaml to conditionally set labels based on workload type.
  • Updated charts/databend-query/values.yaml to include workload field, allowing users to specify StatefulSet or Deployment as the workload type.
  • Added an example file examples/query-cluster-as-deployment.yaml demonstrating usage of Deployment as the workload type.

Impact:

  • Users can now deploy the query component using Deployment as the workload type.
  • Provides flexibility in deployment strategies based on workload requirements.
  • Ensures compatibility with StatefulSet and Deployment workloads.

@everpcpc everpcpc merged commit 1dbde61 into databendlabs:main Mar 29, 2024
2 checks passed
@everpcpc everpcpc deleted the fix-deploy branch March 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant