Chore: fix lint warning

examples/raft-kv-memstore-generic-snapshot-data/src/lib.rs

@@ -36,8 +36,8 @@ openraft::declare_raft_types!(
         AsyncRuntime = TokioRuntime
 );
 
-pub type LogStore = crate::store::LogStore;
-pub type StateMachineStore = crate::store::StateMachineStore;
+pub type LogStore = store::LogStore;
+pub type StateMachineStore = store::StateMachineStore;
 
 pub mod typ {
     use openraft::BasicNode;

examples/raft-kv-memstore-opendal-snapshot-data/src/lib.rs

@@ -35,8 +35,8 @@ openraft::declare_raft_types!(
         AsyncRuntime = TokioRuntime
 );
 
-pub type LogStore = crate::store::LogStore;
-pub type StateMachineStore = crate::store::StateMachineStore;
+pub type LogStore = store::LogStore;
+pub type StateMachineStore = store::StateMachineStore;
 
 pub mod typ {
     use openraft::BasicNode;

examples/raft-kv-memstore-singlethreaded/src/lib.rs

@@ -57,8 +57,8 @@ openraft::declare_raft_types!(
         AsyncRuntime = TokioRuntime
 );
 
-pub type LogStore = crate::store::LogStore;
-pub type StateMachineStore = crate::store::StateMachineStore;
+pub type LogStore = store::LogStore;
+pub type StateMachineStore = store::StateMachineStore;
 pub type Raft = openraft::Raft<TypeConfig>;
 
 pub mod typ {

examples/raft-kv-memstore/src/lib.rs

@@ -33,8 +33,8 @@ openraft::declare_raft_types!(
     Entry = openraft::Entry<TypeConfig>, SnapshotData = Cursor<Vec<u8>>, AsyncRuntime = TokioRuntime
 );
 
-pub type LogStore = crate::store::LogStore;
-pub type StateMachineStore = crate::store::StateMachineStore;
+pub type LogStore = store::LogStore;
+pub type StateMachineStore = store::StateMachineStore;
 pub type Raft = openraft::Raft<TypeConfig>;
 
 pub mod typ {

examples/raft-kv-rocksdb/src/client.rs

@@ -34,7 +34,7 @@ impl ExampleClient {
     pub fn new(leader_id: NodeId, leader_addr: String) -> Self {
         Self {
             leader: Arc::new(Mutex::new((leader_id, leader_addr))),
-            inner: reqwest::Client::new(),
+            inner: Client::new(),
         }
     }
 

openraft/src/core/raft_core.rs

@@ -622,8 +622,8 @@ where
 
     /// Reject a request due to the Raft node being in a state which prohibits the request.
     #[tracing::instrument(level = "trace", skip(self, tx))]
-    pub(crate) fn reject_with_forward_to_leader<T: OptionalSend, E: OptionalSend>(&self, tx: ResultSender<C, T, E>)
-    where E: From<ForwardToLeader<C::NodeId, C::Node>> {
+    pub(crate) fn reject_with_forward_to_leader<T: OptionalSend, E>(&self, tx: ResultSender<C, T, E>)
+    where E: From<ForwardToLeader<C::NodeId, C::Node>> + OptionalSend {
         let mut leader_id = self.current_leader();
         let leader_node = self.get_leader_node(leader_id);
 

openraft/src/entry/mod.rs

@@ -42,7 +42,7 @@ where
 impl<C> Debug for Entry<C>
 where C: RaftTypeConfig
 {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> std::fmt::Result {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.debug_struct("Entry").field("log_id", &self.log_id).field("payload", &self.payload).finish()
     }
 }

openraft/src/network/network.rs

@@ -4,7 +4,6 @@ use std::time::Duration;
 use macros::add_async_trait;
 
 use crate::error::Fatal;
-use crate::error::InstallSnapshotError;
 use crate::error::RPCError;
 use crate::error::RaftError;
 use crate::error::ReplicationClosed;
@@ -13,8 +12,6 @@ use crate::network::rpc_option::RPCOption;
 use crate::network::Backoff;
 use crate::raft::AppendEntriesRequest;
 use crate::raft::AppendEntriesResponse;
-use crate::raft::InstallSnapshotRequest;
-use crate::raft::InstallSnapshotResponse;
 use crate::raft::SnapshotResponse;
 use crate::raft::VoteRequest;
 use crate::raft::VoteResponse;
@@ -47,11 +44,11 @@ where C: RaftTypeConfig
     #[deprecated(since = "0.9.0", note = "use `snapshot()` instead for sending a complete snapshot")]
     async fn install_snapshot(
         &mut self,
-        _rpc: InstallSnapshotRequest<C>,
+        _rpc: crate::raft::InstallSnapshotRequest<C>,
         _option: RPCOption,
     ) -> Result<
-        InstallSnapshotResponse<C::NodeId>,
-        RPCError<C::NodeId, C::Node, RaftError<C::NodeId, InstallSnapshotError>>,
+        crate::raft::InstallSnapshotResponse<C::NodeId>,
+        RPCError<C::NodeId, C::Node, RaftError<C::NodeId, crate::error::InstallSnapshotError>>,
     >;
 
     /// Send a RequestVote RPC to the target.

openraft/src/progress/mod.rs

@@ -63,23 +63,27 @@ where
     }
 
     /// Try to get the value by `id`.
+    #[allow(dead_code)]
     fn try_get(&self, id: &ID) -> Option<&V>;
 
     /// Returns a mutable reference to the value corresponding to the `id`.
     fn get_mut(&mut self, id: &ID) -> Option<&mut V>;
 
     // TODO: merge `get` and `try_get`
     /// Get the value by `id`.
+    #[allow(dead_code)]
     fn get(&self, id: &ID) -> &V;
 
     /// Get the greatest value that is granted by a quorum defined in [`Self::quorum_set()`].
     ///
     /// In raft or other distributed consensus,
     /// To commit a value, the value has to be **granted by a quorum** and has to be the greatest
     /// value every proposed.
+    #[allow(dead_code)]
     fn granted(&self) -> &P;
 
     /// Returns the reference to the quorum set
+    #[allow(dead_code)]
     fn quorum_set(&self) -> &QS;
 
     /// Iterate over all id and values, voters first followed by learners.
@@ -327,6 +331,7 @@ where
         Ok(&self.granted)
     }
 
+    #[allow(dead_code)]
     fn try_get(&self, id: &ID) -> Option<&V> {
         let index = self.index(id)?;
         Some(&self.vector[index].1)
@@ -337,15 +342,18 @@ where
         Some(&mut self.vector[index].1)
     }
 
+    #[allow(dead_code)]
     fn get(&self, id: &ID) -> &V {
         let index = self.index(id).unwrap();
         &self.vector[index].1
     }
 
+    #[allow(dead_code)]
     fn granted(&self) -> &P {
         &self.granted
     }
 
+    #[allow(dead_code)]
     fn quorum_set(&self) -> &QS {
         &self.quorum_set
     }

openraft/src/raft_state/vote_state_reader.rs

@@ -1,7 +1,9 @@
 use crate::NodeId;
 use crate::Vote;
 
+// TODO: remove it?
 /// APIs to get vote.
+#[allow(dead_code)]
 pub(crate) trait VoteStateReader<NID: NodeId> {
     /// Get a reference to the current vote.
     fn vote_ref(&self) -> &Vote<NID>;

openraft/src/testing/suite.rs

@@ -1098,8 +1098,8 @@ where
     }
 }
 
-fn log_id_0<NID: NodeId>(term: u64, index: u64) -> LogId<NID>
-where NID: From<u64> {
+fn log_id_0<NID>(term: u64, index: u64) -> LogId<NID>
+where NID: NodeId + From<u64> {
     LogId {
         leader_id: CommittedLeaderId::new(term, NODE_ID.into()),
         index,

openraft/src/timer/timeout.rs

@@ -15,6 +15,7 @@ use crate::AsyncRuntime;
 use crate::Instant;
 use crate::OptionalSend;
 
+#[allow(dead_code)]
 pub(crate) trait RaftTimer<RT: AsyncRuntime> {
     /// Create a new instance that will call `callback` after `timeout`.
     fn new<F: FnOnce() + OptionalSend + 'static>(callback: F, timeout: Duration) -> Self;
@@ -23,13 +24,15 @@ pub(crate) trait RaftTimer<RT: AsyncRuntime> {
     fn update_timeout(&self, timeout: Duration);
 }
 
+// TODO: remove it.
 /// A oneshot timeout that supports deadline updating.
 ///
 /// When timeout deadline is reached, the `callback: Fn()` is called.
 /// `callback` is guaranteed to be called at most once.
 ///
 /// The deadline can be updated to a higher value then the old deadline won't trigger the
 /// `callback`.
+#[allow(dead_code)]
 pub(crate) struct Timeout<RT: AsyncRuntime> {
     /// A guard to notify the inner-task to quit when it is dropped.
     // tx is not explicitly used.
@@ -40,6 +43,7 @@ pub(crate) struct Timeout<RT: AsyncRuntime> {
     inner: Arc<TimeoutInner<RT>>,
 }
 
+#[allow(dead_code)]
 pub(crate) struct TimeoutInner<RT: AsyncRuntime> {
     /// The time when this Timeout is created.
     ///

openraft/src/vote/leader_id/leader_id_adv.rs

@@ -47,7 +47,7 @@ impl<NID: NodeId> LeaderId<NID> {
     }
 }
 
-impl<NID: NodeId> std::fmt::Display for LeaderId<NID> {
+impl<NID: NodeId> fmt::Display for LeaderId<NID> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}-{}", self.term, self.node_id)
     }

openraft/src/vote/leader_id/leader_id_std.rs

@@ -67,7 +67,7 @@ impl<NID: NodeId> LeaderId<NID> {
     }
 }
 
-impl<NID: NodeId> std::fmt::Display for LeaderId<NID> {
+impl<NID: NodeId> fmt::Display for LeaderId<NID> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}-{:?}", self.term, self.voted_for)
     }
@@ -82,7 +82,7 @@ pub struct CommittedLeaderId<NID> {
     p: PhantomData<NID>,
 }
 
-impl<NID: NodeId> std::fmt::Display for CommittedLeaderId<NID> {
+impl<NID: NodeId> fmt::Display for CommittedLeaderId<NID> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}", self.term)
     }
@@ -96,6 +96,7 @@ impl<NID: NodeId> CommittedLeaderId<NID> {
 }
 
 #[cfg(test)]
+#[allow(clippy::nonminimal_bool)]
 mod tests {
     use crate::CommittedLeaderId;
     use crate::LeaderId;

openraft/src/vote/vote.rs

@@ -105,6 +105,7 @@ impl<NID: NodeId> Vote<NID> {
 }
 
 #[cfg(test)]
+#[allow(clippy::nonminimal_bool)]
 mod tests {
     #[cfg(not(feature = "single-term-leader"))]
     mod feature_no_single_term_leader {

tests/tests/metrics/t20_metrics_state_machine_consistency.rs

@@ -57,7 +57,7 @@ async fn metrics_state_machine_consistency() -> Result<()> {
     for node_id in 0..2 {
         router.wait_for_log(&btreeset![node_id], Some(log_index), None, "write one log").await?;
         let (sto, _sm) = router.get_storage_handle(&node_id)?;
-        assert!(sto.storage().await.get_state_machine().await.client_status.get("foo").is_some());
+        assert!(sto.storage().await.get_state_machine().await.client_status.contains_key("foo"));
     }
 
     Ok(())