Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: even when generic-snapshot-data is enabled, the old chunked transport be still available #1036

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Mar 6, 2024

Changelog

Refactor: even when generic-snapshot-data is enabled, the old chunked transport be still available

If generic-snapshot-data is enabled, the old chunk based transport
such as RaftNetwork::install_snapshot() for sending and
Raft::install_snapshot() for receiving should be still be available
but just deprecated.
This way the application can upgrade Openraft without modification,
except several #[allow(deprecated)] attributes.


This change is Reviewable

…ed transport be still available

If `generic-snapshot-data` is enabled, the old chunk based transport
such as `RaftNetwork::install_snapshot()` for sending and
`Raft::install_snapshot()` for receiving should be still be available
but just deprecated.
This way the application can upgrade Openraft without modification,
except several `#[allow(deprecated)]` attributes.
@drmingdrmer drmingdrmer merged commit 2cc7170 into databendlabs:main Mar 6, 2024
32 checks passed
@drmingdrmer drmingdrmer deleted the 21-loosen-generic-snapshot-shot-constraint branch March 6, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant