Change: Consolidate RaftMetrics type parameters into C
#1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariesdevil
previously approved these changes
Mar 15, 2024
drmingdrmer
force-pushed
the
35-raft-metrics
branch
from
30f08f6 to
bbee288
Compare
The `RaftMetrics` type, along with related metric types, previously used separate type parameters (`NID`, `N`) which have now been replaced with a single generic parameter `C` bound by `RaftTypeConfig`. This modification simplifies the type signatures and usage. Upgrade tip: To adapt to this change, update the metric-related type parameters from separate `NID` and `N` to the single generic `C` constrained by `RaftTypeConfig`: ```rust RaftMetrics<NID, N> --> RaftMetrics<C> RaftDataMetrics<NID> --> RaftDataMetrics<C> RaftServerMetrics<NID, NID> --> RaftServerMetrics<C> Metric<NID> --> Metric<C> Wait<NID, N, A> --> Wait<C> ```
drmingdrmer
force-pushed
the
35-raft-metrics
branch
from
bbee288 to
f049c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Change: Consolidate
RaftMetricstype parameters intoCThe
RaftMetricstype, along with related metric types, previously usedseparate type parameters (
NID,N) which have now been replaced witha single generic parameter
Cbound byRaftTypeConfig. Thismodification simplifies the type signatures and usage.
Upgrade tip:
To adapt to this change, update the metric-related type parameters from
separate
NIDandNto the single genericCconstrained byRaftTypeConfig:This change is