Refactor: Remove redundant storage of last-quorum-acked-time in Leading.vote #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng.vote Previously, `Leading.vote.utime()` held the last timestamp acknowledged by a quorum, marking the beginning of the leader lease. The `Leading` struct updates and calculates this timestamp upon receiving an `AppendEntries` reply (includes heartbeat) from a follower. However, the leader's own timestamp was not being updated in this process. With this commit, we now update the leader's timestamp every time the **last-quorum-acked-time** is accessed. This constant recalculation makes storing the timestamp in `Leading.vote` unnecessary, hence it has been removed to streamline the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Refactor: Remove redundant storage of last-quorum-acked-time in Leading.vote
Previously,
Leading.vote.utime()held the last timestamp acknowledgedby a quorum, marking the beginning of the leader lease. The
Leadingstruct updates and calculates this timestamp upon receiving an
AppendEntriesreply (includes heartbeat) from a follower.However, the leader's own timestamp was not being updated in this
process.
With this commit, we now update the leader's timestamp every time the
last-quorum-acked-time is accessed. This constant recalculation
makes storing the timestamp in
Leading.voteunnecessary, hence it hasbeen removed to streamline the code.
This change is