Fix: Do not report snapshot.last_log_id to metrics until snapshot is finished building/installing #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finished building/installing Before this commit `RaftMetrics.snapshot` contains the last log id of a snapshot that is **going** to install. Therefore there is chance the metrics is updated but the store does not. In this commit, `RaftMetrics.snapshot` will only be updated when a snapshot is finished building or installing, by adding a new field `snpashot` to `IOState` for tracking persisted snapshot meta data. - Fix: databendlabs#912
upgrade thiserror, fix lint warnings.
drmingdrmer
force-pushed
the
44-tracing-log-option
branch
from
f697b5f to
c4a44a2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix: Do not report snapshot.last_log_id to metrics until snapshot is finished building/installing
Before this commit
RaftMetrics.snapshotcontains the last log id of asnapshot that is going to install. Therefore there is chance the
metrics is updated but the store does not.
In this commit,
RaftMetrics.snapshotwill only be updated when asnapshot is finished building or installing, by adding a new field
snpashottoIOStatefor tracking persisted snapshot meta data.This change is