Fixup: raft-kv-metastore example, Arc<Store>::purge_logs_upto issues wrong debug message #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The commit message should starts with |
pfwang80s
changed the title
drmingdrmer
approved these changes
Oct 26, 2023
The title of the commit message is what truly matters, not the title of the pull request. |
pfwang80s
changed the title
|
What I mean is update the commit message to something like this. |
|
Manually merged in main branch:) 0f39431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purge_logs_upto is purging (-oo, log_id], not [log_id, +oo).
This change is