Fix: End tick_loop() when the receiver is gone.
#930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `tick_loop()` would keep printing the trace message every tick even when the receiver (Raft main loop) is gone in this form: `INFO openraft::core::tick: .../tick.rs:70: Tick fails to send, receiving end quit: channel closed` If the tick message fails to send, then terminate the loop, since every future message will fail to send as well. Also adjust the trace message to better describe what happened.
drmingdrmer
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ariesdevil)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
tick_loop()would keep printing the trace message every tick even when the receiver (Raft main loop) is gone in this form:INFO openraft::core::tick: .../tick.rs:70: Tick fails to send, receiving end quit: channel closedIf the tick message fails to send, then terminate the loop, since every future message will fail to send as well.
Also adjust the trace message to better describe what happened.
This change is