Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add License link #932

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Doc: add License link #932

merged 2 commits into from
Nov 14, 2023

Conversation

caicancai
Copy link
Contributor

@caicancai caicancai commented Nov 14, 2023

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@caicancai
Copy link
Contributor Author

@drmingdrmer Hi, I found that my previous mention in the main branch seemed a little unreasonable, so I re-mentioned a pr, for which I am sorry

@drmingdrmer
Copy link
Member

It has come to my attention that the README file is also utilized on docs.rs. Therefore, using local links could lead to broken links on the docs.rs platform.

@caicancai
Copy link
Contributor Author

It has come to my attention that the README file is also utilized on docs.rs. Therefore, using local links could lead to broken links on the docs.rs platform.

Thanks for reminding me. I'll change the official link

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @caicancai)

@drmingdrmer drmingdrmer added this pull request to the merge queue Nov 14, 2023
@drmingdrmer drmingdrmer removed this pull request from the merge queue due to a manual request Nov 14, 2023
@drmingdrmer drmingdrmer added this pull request to the merge queue Nov 14, 2023
Merged via the queue into databendlabs:main with commit 2963787 Nov 14, 2023
24 checks passed
@caicancai
Copy link
Contributor Author

I seem to have typed one space less, and I'm sorry for that

@caicancai caicancai deleted the license_link branch November 15, 2023 02:05
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants