Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Wait::eq() and ge() to await a metics #967

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 11, 2023

Changelog

Feature: add Wait::eq() and ge() to await a metics

Wait does not need many method for each metric. In this commit, it
provides method eq() and ge() to specify waiting condition in a
general way. The metric to await is specified by Metric as the first
argument.

my_raft.wait(None).ge(Metric::Term(2), "").await?

This change is Reviewable

`Wait` does not need many method for each metric. In this commit, it
provides method `eq()` and `ge()` to specify waiting condition in a
general way. The metric to await is specified by `Metric` as the first
argument.

```rust
my_raft.wait(None).ge(Metric::Term(2), "").await?
```
@drmingdrmer drmingdrmer merged commit f0576e5 into databendlabs:main Dec 11, 2023
25 checks passed
@drmingdrmer drmingdrmer deleted the 55-wait branch December 11, 2023 11:48
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant