Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: update raft-kv-memstore example to use storage v2 #977

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

tvsfx
Copy link
Contributor

@tvsfx tvsfx commented Dec 20, 2023

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@tvsfx tvsfx force-pushed the raft-kv-memstore-storage-v2 branch from fbbbdb2 to bfbe8c5 Compare December 20, 2023 13:25
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tvsfx)

@drmingdrmer drmingdrmer merged commit 5403e0e into databendlabs:main Dec 20, 2023
23 of 24 checks passed
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants