Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to pipestat 0.6.0 #199

Merged
merged 9 commits into from
Nov 10, 2023
Merged

updated to pipestat 0.6.0 #199

merged 9 commits into from
Nov 10, 2023

Conversation

khoroshevskyi
Copy link
Member

No description provided.

pypiper/manager.py Outdated Show resolved Hide resolved
pypiper/manager.py Outdated Show resolved Hide resolved
pypiper/manager.py Outdated Show resolved Hide resolved
@@ -1113,6 +1113,8 @@ def _add_args(parser, args, required):
def result_formatter_markdown(pipeline_name, record_identifier, res_id, value) -> str:
"""
Returns Markdown formatted value as string

# Pipeline_name and record_identifier should be kept because pipestat needs it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the input be changed to be more general **kwargs?

Copy link
Member

@donaldcampbelljr donaldcampbelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things but none are necessary

@donaldcampbelljr donaldcampbelljr merged commit 4db1637 into dev Nov 10, 2023
3 checks passed
@donaldcampbelljr donaldcampbelljr deleted the new_pipestat branch November 10, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants