Fix some map(overwrite=True) bugs
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
commented
Jan 5, 2024
| @@ -2664,17 +2665,6 @@ def map( | |||
| field = manifest.data_schema.get_field(output_path) | |||
| if field.map is None: | |||
| raise ValueError(f'{output_path} is not a map column so it cannot be overwritten.') | |||
| # Delete the parquet file and map manifest. | |||
There was a problem hiding this comment.
we don't need this code since the parquet file and the map manifest are deleted/overwritten when we reshard. This makes map(input=x, output=x, overwrite=True) work
nsthorat
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix progress bar when overwrite=True and allow
map(input=x, output=x, overwrite=True)